chore: do not bundle scip on docs.rs #81
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@lovasoa one idea about this: we could introduce a new feature called I did not perform this change because I don't like adding features just for ease of maintenance. But if you think it's better to have this, I can update the branch. |
lovasoa
approved these changes
Jan 7, 2025
KnorpelSenf
added a commit
to KnorpelSenf/good_lp
that referenced
this pull request
Jan 22, 2025
* chore: do not bundle scip on docs.rs * docs: add comment on docs.rs features
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes the build on docs.rs to avoid network access. This was introduced in #72 because bundling scip simplifies the build setup in both CI and locally.
Fixes #77.