Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(msr): add IA32_APIC_BASE support #532

Merged
merged 5 commits into from
Jan 29, 2025
Merged

Conversation

hannahfluch
Copy link
Contributor

The IA32_APIC_BASE model-specifc register is for the configuration of the Advanced Programmable Interrupt Controller. This addition provides support for interacting with this MSR, since it is frequently used in modern OS development.

More information can be found in the Intel® 64 and IA-32 Architectures Software Developer’s Manual Volume 3 (3A, 3B, 3C, & 3D): System Programming Guide in section 11.4.4 Local APIC Status and Location

Copy link
Member

@Freax13 Freax13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution!

src/registers/model_specific.rs Outdated Show resolved Hide resolved
src/registers/model_specific.rs Outdated Show resolved Hide resolved
src/registers/model_specific.rs Outdated Show resolved Hide resolved
src/registers/model_specific.rs Outdated Show resolved Hide resolved
@hannahfluch hannahfluch requested a review from Freax13 January 28, 2025 09:45
Copy link
Member

@Freax13 Freax13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few more cosmetic changes, but once these are addressed, I think we can soon merge this. Sorry for being pedantic.

src/registers/model_specific.rs Outdated Show resolved Hide resolved
src/registers/model_specific.rs Outdated Show resolved Hide resolved
src/registers/model_specific.rs Outdated Show resolved Hide resolved
src/registers/model_specific.rs Outdated Show resolved Hide resolved
@hannahfluch
Copy link
Contributor Author

Thanks for the feedback, let me know if I should change anything else :)

@hannahfluch hannahfluch requested a review from Freax13 January 28, 2025 20:37
Copy link
Member

@Freax13 Freax13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@Freax13 Freax13 enabled auto-merge January 29, 2025 06:41
@Freax13 Freax13 merged commit dc43e5a into rust-osdev:master Jan 29, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants