-
Notifications
You must be signed in to change notification settings - Fork 139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(msr): add IA32_APIC_BASE support #532
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your contribution!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few more cosmetic changes, but once these are addressed, I think we can soon merge this. Sorry for being pedantic.
Thanks for the feedback, let me know if I should change anything else :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
The IA32_APIC_BASE model-specifc register is for the configuration of the Advanced Programmable Interrupt Controller. This addition provides support for interacting with this MSR, since it is frequently used in modern OS development.
More information can be found in the Intel® 64 and IA-32 Architectures Software Developer’s Manual Volume 3 (3A, 3B, 3C, & 3D): System Programming Guide in section 11.4.4 Local APIC Status and Location