vfio-ioctls: Add support for vfio cdev and iommufd #127
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
likebreath
force-pushed
the
1215/vfio_cdev_iommufd
branch
3 times, most recently
from
425f6a2 to
72b4842
Compare
likebreath
requested review from
jiangliu,
jinankjain,
liuw,
rbradford,
russell-islam,
sameo and
sboeuf
as code owners
Collaborator
Author
|
@up2wing You might be interested. Please take a look. Thank you. |
Cool, thx for the notify. I'll see this ASAP. |
likebreath
force-pushed
the
1215/vfio_cdev_iommufd
branch
from
72b4842 to
f3f6f7b
Compare
up2wing
reviewed
Dec 22, 2025
likebreath
force-pushed
the
1215/vfio_cdev_iommufd
branch
from
f3f6f7b to
a4d6608
Compare
Collaborator
Author
|
@up2wing Thank you for the thorough review. All comments are addressed. Please take another look. Also, inspired by one of your comments, I fixed a similar ioctl mutability issue from cloud-hypervisor/iommufd#2. |
likebreath
force-pushed
the
1215/vfio_cdev_iommufd
branch
from
a4d6608 to
7f4a7ab
Compare
The new ioctls are also put behind a feature flag `vfio_cdev`. Signed-off-by: Bo Chen <bchen@crusoe.ai>
likebreath
force-pushed
the
1215/vfio_cdev_iommufd
branch
from
7f4a7ab to
63a1f92
Compare
up2wing
approved these changes
Jan 2, 2026
up2wing
left a comment
up2wing
left a comment
There was a problem hiding this comment.
There is only one spelling issue left, the code LGTM.
This patch introduces `pub struct VfioIommufd`, a safe wrapper for VFIO devices backed by the cdev interface and iommufd. This struct implements the `VfioOps` trait to provide APIs for userspace drivers (e.g., a VMM). Additionally, this patch extends the `VfioDevice` constructor to support creating instances using the new VfioIommufd backend. Fixes: rust-vmm#92 Signed-off-by: Bo Chen <bchen@crusoe.ai>
likebreath
force-pushed
the
1215/vfio_cdev_iommufd
branch
from
63a1f92 to
d058300
Compare
Collaborator
Author
|
@liuw @rbradford Can you please take a look? Thank you. |
liuw
approved these changes
Jan 9, 2026
rbradford
approved these changes
Jan 13, 2026
Collaborator
Author
|
The only failure on |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the PR
This patch introduces
pub struct VfioIommufd, a safe wrapper for VFIOdevices backed by the cdev interface and iommufd. This struct implements
the
VfioOpstrait to provide APIs for userspace drivers (e.g., a VMM).Additionally, this patch extends the
VfioDeviceconstructor to supportcreating instances using the new
VfioIommufdbackend.Of course, new vfio ioctls are introduced to support for the cdev interface.
All changes are put behind the feature flag
vfio_cdev.Fixes: #92
Signed-off-by: Bo Chen bchen@crusoe.ai
Requirements
Before submitting your PR, please make sure you addressed the following
requirements:
git commit -s), and the commit message has max 60 characters for thesummary and max 75 characters for each description line.
test.
Release" section of CHANGELOG.md (if no such section exists, please create one).
unsafecode is properly documented.