-
-
Notifications
You must be signed in to change notification settings - Fork 477
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ci): add OpenHarmony ci support #1703
Conversation
The CI of ohos needs to do some extra processing, and I will explain why it is implemented in this way:
Could you provide some advice? @MarijnS95 |
|
Yep, so should we upgrade MSRV to 1.78.0? If just run |
tbf, instead of adding more targets, I'd rather remove If you pass e.g. Android handle on general linux stuff, nothing wrong will happen, you'll just get an error and that's about it. |
@kchibisov I've previously tried to add
Please don't post screenshots but copy-paste logs/code/links, as they are hard to find/reference/quote otherwise. |
@MarijnS95 we have x11/wayland cfgs for a reason to not build x11/wayland deps, since we use them. The rest doesn't have any system deps, so it all doesn't matter for them. Like |
@kchibisov I think you are saying the same thing. See the following example, where the glutin/glutin/src/api/egl/display.rs Lines 257 to 271 in dae89a5
(Hence I removed them in the previously linked commit/PR) |
yeah, that's fine then. |
Handled in #1707 We just always build the code for harmony now. |
Add minimal OpenHarmony CI testing as requested in #1702 (comment).
CHANGELOG.md
if knowledge of this change could be valuable to users