-
Notifications
You must be signed in to change notification settings - Fork 891
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Explicitly demarcate platform support #3887
Conversation
d0923f4
to
fbfad5c
Compare
Should probably put it in a separate file, since we'll remove the |
84b1579
to
c5abd0c
Compare
Done and done |
c5abd0c
to
e03fd35
Compare
For the initial draft here I've gone with more platforms than we probably need. I think all the tier 1's are necessary, since we actively test them in CI and they directly correspond to the canonical versions of the For the tier 2's:
|
e03fd35
to
0f047ff
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved once the data is deduplicated somehow (see first comment)
0f047ff
to
c52d0e8
Compare
ceb486d
to
dd5f448
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this requires a tier 3?
E.g. tier 2 is actually tested in CI, tier 3 is not but we believe it should work?
Unless we want to actually just go ahead and test them in CI (which I would be in favor of), then we should do this right here.
Or am I missing something?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I went ahead and adjusted the wording around Web as I suggested.
da77cdb
to
a3aa76e
Compare
As discussed in today's meeting, this commit creates two tiers of support. Tier 1, which is what we actively test, and Tier 2, what we hope compiles. Signed-off-by: John Nunley <dev@notgull.net> Co-authored-by: daxpedda <daxpedda@gmail.com>
a3aa76e
to
627c621
Compare
As discussed in today's meeting, this commit creates two tiers of
support. Tier 1, which is what we actively test, and Tier 2, what we
hope compiles.