Provide distinct event number for types defined by reference #276
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Unfortunately, this change has the potential to break user code that relied on the type def representing these types. For example, in |
Prior to this commit, message types defined by reference were exposed to Rust as type aliases, such as `type KeyReleaseEvent = KeyPressEvent;`. As a result, they shared a single implementation of `BaseEvent`, erroneously sharing the same `BaseEvent::NUMBER`. This commit updates the code generation to instead expose these types as a wrapper struct, such as `struct KeyReleaseEvent(KeyPressEvent);`. These wrapper structs expose the same methods, but have an independent implementation of `BaseEvent`. This allows these events to be constructed, such as for use in `SendEvent`. Fixes rust-x-bindings#214
Lunderberg
force-pushed
the
distinct-types-when-defined-by-reference
branch
from
d95a206 to
1ddeeb1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this commit, message types defined by reference were exposed to Rust as type aliases, such as
type KeyReleaseEvent = KeyPressEvent;. As a result, they shared a single implementation ofBaseEvent, erroneously sharing the sameBaseEvent::NUMBER.This commit updates the code generation to instead expose these types as a wrapper struct, such as
struct KeyReleaseEvent(KeyPressEvent);. These wrapper structs expose the same methods, but have an independent implementation ofBaseEvent. This allows these events to be constructed, such as for use inSendEvent.Fixes #214