Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: enable mouse move event when mouse is pressed on macos #12

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

HuakunShen
Copy link

On MacOS, when mouse is pressed, no move event is emitted.
This prevents me from detecting drag event.

On both windows and linux, move event is emitted when mouse is pressed.

I think it's a better idea to add MouseDrag event to EventType, because Mac's native API already have this CGEventType::LeftMouseDragged.

But this requires also updating windows and linux API to stay consistent.
I may work on that later. This PR makes rdev behave the same way on all platforms.

@rustdesk
Copy link
Collaborator

@fufesou

@fufesou
Copy link

fufesou commented Dec 11, 2024

This PR works good.

  1. Could you please change the example filename. simple.rs is not a good name.
  2. Is there any way to support center(scroll) button, forward and backword buttons? This API is not good enough to support those events
    let tap = CGEventTapCreate(

I think it's a better idea to add MouseDrag event to EventType, because Mac's native API already have this CGEventType::LeftMouseDragged.

I'm not sure about it. Press flag and MouseMove event look enough to me.

@HuakunShen
Copy link
Author

@fufesou I removed the simple.rs example

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants