fix: CI — nixpkgs-fmt formatting violations and mkRenamedOptionModule arity#18
Conversation
…e 3-arg call Co-authored-by: houseme <4829346+houseme@users.noreply.github.com>
|
@copilot 'actions/checkout@v6' is the stable version |
Co-authored-by: houseme <4829346+houseme@users.noreply.github.com>
Restored to |
There was a problem hiding this comment.
Pull request overview
This PR fixes CI failures introduced by the new workflow by correcting a NixOS module evaluation error and aligning example/config files with nixpkgs-fmt formatting requirements.
Changes:
- Fix
lib.mkRenamedOptionModuleusage in the RustFS NixOS module by removing an invalid third argument that breaksnix flake checkduring module evaluation. - Apply
nixpkgs-fmt-compatible formatting updates innixos/rustfs.nix(argument list and expression indentation). - Remove trailing whitespace on blank lines in example Nix files to satisfy
nixpkgs-fmt --check.
Reviewed changes
Copilot reviewed 1 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
nixos/rustfs.nix |
Fixes module evaluation by correcting mkRenamedOptionModule arity and applies canonical nixpkgs-fmt formatting. |
examples/nixos-configuration.nix |
Removes trailing whitespace on blank lines to satisfy formatter checks. |
examples/flake.nix |
Removes trailing whitespace on blank lines to satisfy formatter checks. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
* feat: Issue #9 improvements and documentation reorganization - Remove manual binary stripping and binutils - Clarify sourceProvenance for pre-compiled binaries - Migrate to environment attribute set (nixpkgs best practice) - Replace shell script with %d placeholder - Default to systemd journal logging - Move detailed docs to docs/, remove duplicates - Update all documentation references * fix: combine duplicate allowedTCPPorts into single list in firewall example (#16) * Initial plan * fix: combine duplicate allowedTCPPorts into single list in firewall example Co-authored-by: houseme <4829346+houseme@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: houseme <4829346+houseme@users.noreply.github.com> * fix: address PR #15 review feedback — secrets handling, broken links, optional logDirectory (#17) * Initial plan * fix: address remaining review comments - secrets handling, broken links, optional logDirectory Co-authored-by: houseme <4829346+houseme@users.noreply.github.com> * fix: clarify CHANGELOG deprecated accessKey/secretKey semantics and required file path Co-authored-by: houseme <4829346+houseme@users.noreply.github.com> * fix: remove hardcoded secrets from activation script example; align README with LoadCredential behavior Co-authored-by: houseme <4829346+houseme@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: houseme <4829346+houseme@users.noreply.github.com> * add workflows config * fix: CI — nixpkgs-fmt formatting violations and mkRenamedOptionModule arity (#18) * Initial plan * fix: resolve CI errors — invalid checkout@v6 and mkRenamedOptionModule 3-arg call Co-authored-by: houseme <4829346+houseme@users.noreply.github.com> * fix: apply nixpkgs-fmt to all 3 failing files and restore checkout@v6 Co-authored-by: houseme <4829346+houseme@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: houseme <4829346+houseme@users.noreply.github.com> --------- Co-authored-by: Copilot <198982749+Copilot@users.noreply.github.com> Co-authored-by: houseme <4829346+houseme@users.noreply.github.com>
Three issues prevented CI from running successfully after the workflow was introduced.
Changes
nixos/rustfs.nix—lib.mkRenamedOptionModuleaccepts exactly 2 arguments(from: [String]) → (to: [String]) → Module; the spurious 3rd string argument would causenix flake checkto fail at module evaluation timeexamples/flake.nix— Remove trailing whitespace on blank line (nixpkgs-fmt compliance)examples/nixos-configuration.nix— Remove trailing whitespace on blank lines (nixpkgs-fmt compliance)nixos/rustfs.nix— Reformat to nixpkgs-fmt canonical style: function argument list style,if-then-elseindentation, and++chain indentation💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.