Check-in Cargo.lock, fix MSRV build #78
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is now a recommended practice for libraries and makes maintaining our MSRV much easier.
This is a compromise between running on all pushes vs only running for main/PRs that still allows easy on-demand CI runs while developing.
djc
approved these changes
Jul 9, 2024
|
@quininer This feels small & uncontroversial enough to merge as-is, but if you have any feedback I'm happy to iterate or revert as needed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Presently CI's MSRV job is failing with the error:
Following updated guidance on the matter and the other Rustls repos, this branch checks in a
Cargo.lockfile. By doing so after runningcargo update -Z minimal-versions -p ccw/ a nightly compiler we carefully pin theCargo.lockversion of the dep to ensure the MSRV builds succeeds.Along the way I also tweaked the CI trigger conditions to allow easier testing before opening a PR.