Update pqcrypto-internals build.rs to support iOS SDK 18.1 #72
Conversation
Darwin runners fail after the update of this crate which is a transient dependency. Using `[patch]` doesn't update properly so this is a manual attempt. There's outstanding PR which claims to fix the issue: rustpq/pqcrypto#72 The error in question from compilation: ``` cargo:warning=<instantiation>:79:5: error: instruction requires: sha3 ``` Signed-off-by: Lukas Pukenis <lukas.pukenis@nordsec.com>
Darwin runners fail after the update of this crate which is a transient dependency. Using `[patch]` doesn't update properly so this is a manual attempt. There's outstanding PR which claims to fix the issue: rustpq/pqcrypto#72 The error in question from compilation: ``` cargo:warning=<instantiation>:79:5: error: instruction requires: sha3 ``` Signed-off-by: Lukas Pukenis <lukas.pukenis@nordsec.com>
thomwiggers
force-pushed
the
build_ios_sdk_18_1
branch
from
86762e3 to
7fcb107
Compare
Head branch was pushed to by a user without write access
|
@gridbox Thank you very much for this fix, this worked for me and fixed the compiling issue when trying to build for |
thomwiggers
force-pushed
the
build_ios_sdk_18_1
branch
from
e4fe2d7 to
e3b6f66
Compare
|
Also it seems like it breaks the build for Android aarch64 |
|
If you could contribute a test case that covers cross-compiling for Android, that would be great. I don't have a lot of time to work on this project. |
|
The tricky thing about what we're trying to build in |
|
It's totally understandable, thank you for your effort and the quick reply. How would you like to see the test case? A Github workflow or something else? |
|
This should likely just be integrated into the Github workflow, I don't think we could specify build flags otherwise. |
|
Here's a quick fix that fixes the problem for android: #74 |
I was still experiencing
sha3error even with version 0.2.7. I noticed the OP in #68 was using iOS SDK 17.2. I have since updated to Xcode 16 which is at iOS SDK 18.1 and the build flag did not fix it. However, through some searching I found that updating the build flag to-march=armv8-a+sha3seems to work.Unfortunately, I'm not using the library directly but it is an indirect dependency of another dependency that I am using to build a Flutter mobile app backed by a custom Rust library. I'm not sure if my fix is universal or is just appropriate for my specific use case.