-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for broadcasting Ruuvi Sensor Data service UUID (and any other service UUID) #356
Conversation
Reviewpad Report
|
@TheSomeMan This PR adds a firmware variant that advertises Ruuvi service UUID. To fit the UUID in, a new shorter data format C5 is added, and drivers have been extended to support UUID advertising. Especially src/app_dataformats.c data format cycling logic should be checked together with src/app_heartbeat.c enabled data format definition. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good 👍
src/app_dataformats.c
Outdated
return DF_5; | ||
app_dataformat_t nextState = DF_INVALID; | ||
|
||
if (formats.formats) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggestion from SonarCloud: Explicitly test this expression against zero.
Quality Gate passedKudos, no new issues were introduced! 0 New issues |
This should help some phones on their background scan.