fix: safe PyTorch model loading (weights_only=True)#133
Merged
Conversation
Replace unsafe `torch.load(path)` with `torch.load(path, map_location=self.device, weights_only=True)` to prevent pickle deserialization RCE (trailofbits.python.pickles-in-pytorch). weights_only=True disables pickle entirely for model loading, which is the PyTorch-recommended mitigation (available since 1.13). Also adds map_location for correct CPU/GPU device mapping. Closes #106 Co-Authored-By: claude-flow <ruv@ruv.net>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
torch.load(path)withtorch.load(path, map_location=self.device, weights_only=True)inreferences/wifi_densepose_pytorch.pytrailofbits.python.pickles-in-pytorch)map_locationfor correct CPU/GPU device mappingThis is the correct fix for the vulnerability identified in PR #106 (now closed). That PR introduced a custom
RestrictedUnpicklerwhich had several issues (missingimport pickle, brokentorch.savereplacement, ignoredmap_location, incomplete allowlist). PyTorch's built-inweights_only=True(available since 1.13) is the recommended mitigation — it disables pickle entirely for model loading.Test plan
load_model()works with existing.pthcheckpointsweights_only=True🤖 Generated with claude-flow