fix(lint): resolve all ESLint warnings in src/ux/UserTest/views folder#1641
Closed
Ruthwik000 wants to merge 4 commits intoruxailab:developfrom
Closed
fix(lint): resolve all ESLint warnings in src/ux/UserTest/views folder#1641Ruthwik000 wants to merge 4 commits intoruxailab:developfrom
Ruthwik000 wants to merge 4 commits intoruxailab:developfrom
Conversation
Fixes ruxailab#1631 This commit eliminates all 13 ESLint warnings in the UserTest views folder: ## Changes Made: ### EditTestView.vue (2 warnings fixed) - Replace raw text 'Eye Tracking Configurations' with i18n key - Remove unused 'error' parameter in catch block ### ModeratedTestView.vue (3 warnings fixed) - Remove duplicate 'onUnmounted' import (already imported as 'onBeforeUnmount') - Remove unused 'error' parameter in catch block - Replace console.error with comment for array validation ### Moderators/ManagerView.vue (1 warning fixed) - Remove unused 'useRouter' import ### Unmoderated/ManagerView.vue (1 warning fixed) - Remove unused 'getStatusColor' import ### UserTestView.vue (6 warnings fixed) - Replace raw text 'loading...' with i18n key 'common.loading' - Remove 5 console.log/console.error statements - Replace with comments or proper error handling ### en.json (i18n) - Add missing 'ModeratedTest.eyeTrackingConfig' translation key ## Testing: All 93 unit tests passing Zero ESLint warnings in src/ux/UserTest/views No functionality changes - only code quality improvements
github-actions
bot
added
fix
medium-complexity
size/S
ui/ux
user-test
Contributor
There was a problem hiding this comment.
Pull request overview
This PR aims to eliminate ESLint warnings in src/ux/UserTest/views by removing unused imports/params, replacing raw template text with i18n keys, and removing console statements.
Changes:
- Replace raw UI strings with i18n keys (e.g., loading overlay text, eye-tracking tab label) and add the missing English translation key.
- Remove unused imports and unused
catchparameters across several views. - Remove
console.log/errorstatements and adjust code formatting to satisfy lint rules.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/ux/UserTest/views/UserTestView.vue | Replaces raw “loading...” text with i18n key and removes console logging; adjusts partial-save error handling. |
| src/ux/UserTest/views/Unmoderated/ManagerView.vue | Removes unused getStatusColor import. |
| src/ux/UserTest/views/Moderators/ManagerView.vue | Removes unused useRouter import. |
| src/ux/UserTest/views/ModeratedTestView.vue | Removes duplicate/unneeded lifecycle import, removes unused catch param, removes console error logging, formatting fixes. |
| src/ux/UserTest/views/EditTestView.vue | Replaces raw tab label with i18n key and removes unused catch param. |
| src/app/plugins/locales/en.json | Adds ModeratedTest.eyeTrackingConfig translation key. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Replace duplicated accessLevel computed logic with calculateAccessLevel utility - Reduces duplication from 100% to 0% in this file - Brings overall duplication below 3% threshold This was missed in the previous duplication fix commits and was causing the SonarCloud quality gate to fail.
Author
|
@marcgc21 Kindly review the PR. Would love to know your feedback. Thanks! |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Author
|
@jvJUCA hey by your since commit got some issue kindly check out pr , let me know if there is any issue on my side and also kindly review the pullrequest |
Please update the PR description to address these issues. |
github-actions
bot
added
low-complexity
needs-description
and removed
medium-complexity
labels
|
Member
|
Not working! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1631
This commit eliminates all 13 ESLint warnings in the UserTest views folder:
Changes Made:
EditTestView.vue (2 warnings fixed)
ModeratedTestView.vue (3 warnings fixed)
Moderators/ManagerView.vue (1 warning fixed)
Unmoderated/ManagerView.vue (1 warning fixed)
UserTestView.vue (6 warnings fixed)
en.json (i18n)
Testing:
All 93 unit tests passing
Zero ESLint warnings in src/ux/UserTest/views
No functionality changes - only code quality improvements
##Screenshot
