Skip to content

Fix XSS warning by removing HTML from i18n translations#1670

Merged
marcgc21 merged 2 commits intoruxailab:developfrom
rahul810050:fix/i18n-xss-warning
Feb 24, 2026
Merged

Fix XSS warning by removing HTML from i18n translations#1670
marcgc21 merged 2 commits intoruxailab:developfrom
rahul810050:fix/i18n-xss-warning

Conversation

@rahul810050
Copy link
Contributor

@rahul810050 rahul810050 commented Feb 12, 2026

Fixed issue: #1669

PR Summary

This PR removes HTML tags from i18n translation strings and replaces v-html
usage with safe Vue interpolation.

This resolves the vue-i18n / intlify XSS warning and follows recommended
security best practices by keeping translations as plain text.

Before:
image

After:
image

Signed-off-by: rahul810050 <rahul810050@gmail.com>
@github-actions
Copy link

github-actions bot commented Feb 12, 2026

⚠️ PR Description Issues Detected

Please update the PR description to address these issues.

@rahul810050
Copy link
Contributor Author

@marcgc21 @jvJUCA please review it🙏

Copy link
Contributor

@DivyanshuVortex DivyanshuVortex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR looks good. Could you please add the missing key to the other locale files as well?

Image

@harsshks
Copy link

Hi @rahul810050! 👋

I noticed the i18n validation is failing because the new translation key needs to be added to all locale files. I'd be happy to help with this!

The missing key needs to be added to:

  • es.json
  • pt_br.json
  • hi.json
  • de.json
  • fr.json
  • zh.json
  • ar.json
  • ru.json
  • ja.json

Would you like me to:

  1. Push a commit to your branch (if you give me collaborator access), or
  2. Create a follow-up PR once yours is merged, or
  3. Share the exact changes needed so you can add them?

Let me know how I can help! 🚀

@rahul810050
Copy link
Contributor Author

This PR looks good. Could you please add the missing key to the other locale files as well?

Image

Thanks for reviewing the pr @DivyanshuVortex !!
sure I will update the pr asap

@rahul810050
Copy link
Contributor Author

Hi @rahul810050! 👋

I noticed the i18n validation is failing because the new translation key needs to be added to all locale files. I'd be happy to help with this!

The missing key needs to be added to:

  • es.json
  • pt_br.json
  • hi.json
  • de.json
  • fr.json
  • zh.json
  • ar.json
  • ru.json
  • ja.json

Would you like me to:

  1. Push a commit to your branch (if you give me collaborator access), or
  2. Create a follow-up PR once yours is merged, or
  3. Share the exact changes needed so you can add them?

Let me know how I can help! 🚀

Hii @harsshks !!
i appreciate your interest but i think it would be nice if i push all the translation files in this pr itself...

Signed-off-by: rahul810050 <rahul810050@gmail.com>
@sonarqubecloud
Copy link

@marcgc21 marcgc21 merged commit cbe8405 into ruxailab:develop Feb 24, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants