Open
Conversation
github-actions
bot
added
Documentation
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #1700
Added format and format:check in package.json on src files with .vue and .js
Looking at lint-staged which runs prettier --write only on [*.{js,vue}] and the pre-commit hook runs npx lint-staged and .prettierignore explicitly ignores dist and node_modules and src/node_modules. So kept formatting only for Vue/JS under src.
Before:
After:
Updated formatting and test commands for unit, end to end and formatting in CONTRIBUTING.md
Ran all codes in CONTRIBUTING.md after change. No Missing Script error occured so all commands are in package.json