Skip to content

fix: resolve UnboundLocalError for 'results' variable in process_pull_request #62

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
1234-ad wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: resolve UnboundLocalError for 'results' variable in process_pull_request #62

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 12 additions & 4 deletions pr_review/main.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,14 @@ def process_pull_request(self, repo: str, pr_number: int, experience_level: str
Returns:
Processing results
"""
# Initialize results early to avoid UnboundLocalError
results = {
'pr_number': pr_number,
'repository': repo,
'status': 'error',
'error': 'Unknown error occurred'
}

try:
logger.info(f"Processing PR #{pr_number} in {repo}")

Expand Down Expand Up @@ -105,10 +113,7 @@ def process_pull_request(self, repo: str, pr_number: int, experience_level: str

self.github_client.create_issue_comment(repo, pr_number, comment_body)

# Send Discord notification
asyncio.create_task(self._send_discord_notification(results, comment_body))

# Return processing results
# Update results with success data BEFORE sending notification
results = {
'pr_number': pr_number,
'repository': repo,
Expand All @@ -119,6 +124,9 @@ def process_pull_request(self, repo: str, pr_number: int, experience_level: str
'status': 'success'
}

# Send Discord notification with properly initialized results
asyncio.create_task(self._send_discord_notification(results, comment_body))

logger.info(f"Successfully processed PR #{pr_number}")
return results

Expand Down