Fix inconsistent model training approach in trian_and_predict function#72
Open
sohampirale wants to merge 1 commit intoruxailab:mainfrom
Open
Fix inconsistent model training approach in trian_and_predict function#72sohampirale wants to merge 1 commit intoruxailab:mainfrom
sohampirale wants to merge 1 commit intoruxailab:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes an inconsistency in the
trian_and_predictfunction where models were not being handled according to their hyperparameter configurations.Fixes : #71
Solution
Updated the conditional logic to properly align model usage with hyperparameter availability:
IF block (simple fitting): Models without hyperparameters in
config.pyELSE block (
GridSearchCV): Models with hyperparameters inconfig.pyFiles Changed
app/services/gaze_tracker.py: Updated the conditional logic intrian_and_predictfunctionScreenshots (tested with all 3 models)