Add fullscreen calibration mode and fix camera preview clipping#103
Open
harsshks wants to merge 2 commits intoruxailab:mainfrom
Open
Add fullscreen calibration mode and fix camera preview clipping#103harsshks wants to merge 2 commits intoruxailab:mainfrom
harsshks wants to merge 2 commits intoruxailab:mainfrom
Conversation
Author
✅ Conflicts Resolved & Ready for ReviewI've successfully resolved the merge conflicts and updated this PR with the latest changes from main. Here's a summary of what this PR implements: 🎯 Core Features Implemented1. Fullscreen Calibration Mode
2. Camera Preview Fixes
|
- Enter fullscreen during training and validation - Exit fullscreen on completion or route leave - Fix camera preview being clipped by stepper container - Allow natural scrolling during calibration Fixes ruxailab#100
- Add calibration mode selection (multi-point vs single-point) - Update store with calibrationMode state and mutations - Add single-point pattern generation (center screen) - Update DoubleCalibrationRecord.vue to support single-point mode - Add calibration mode selector in CameraConfiguration.vue - Dynamic stepper content based on calibration mode - Maintain backward compatibility with existing multi-point mode Features: - Quick single-point calibration for faster setup - Lower accuracy trade-off for speed - Center screen point positioning - Dynamic UI based on selected mode - Proper state management integration Addresses ruxailab#99
harsshks
force-pushed
the
feat/fullscreen-calibration
branch
from
b36b336 to
7820163
Compare
Author
|
Hi @jvJUCA , Just a quick follow-up on this PR. I’ve rebased with the latest main and resolved the merge conflicts in:
Everything is now up to date and should merge cleanly. Please let me know if any further changes are required from my side. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does
Root cause
Camera preview was being clipped by a parent stepper container using
max-height+overflow: hidden.Fix
Testing
Fixes #100