Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor of multiple files, added VGSL Spec, unittests #2

Merged
merged 44 commits into from
Sep 25, 2023
Merged

Refactor of multiple files, added VGSL Spec, unittests #2

merged 44 commits into from
Sep 25, 2023

Conversation

TimKoornstra
Copy link
Collaborator

This release adds

  • Unittests for the most-used classes
  • Github actions runs unittests on push/pull request
  • The introduction of VGSL spec-type model creation
  • Improved README.md

Notes:

  • New models must now be created with either a VGSL spec string, or "model" + the version number corresponding to the "old" way of creating models. For example, --model new17 becomes --model model17.

TimKoornstra and others added 30 commits August 3, 2023 15:36
@TimKoornstra
Initial cleaning of Model.py and main.py
c918a0b 
Main changes: removal of unreachable code and different build
functions (only 1 left for now). Reordering of some imports
@TimKoornstra
Clean more redundant code, improve imports clarity
f09ea02
@TimKoornstra
Add initial basic model creation test and minor improvement in
6131517 
main.py
@TimKoornstra
New round of main.py cleaning
fe3336e 
Simplify some loops, move arguments to arg_parser.py and
categorize them
@TimKoornstra
First DataLoaderNew unittests + minor changes
8185626
@TimKoornstra
Finish DataLoaderNew tests, add extra docstring to model_creation
c578ace
@TimKoornstra
Created DataGeneratorNew2 tests. Limited tf warnings for creation.
7840397
@TimKoornstra
Added tests for utils.py. Removed redundant code in test_datagenerator
8d877fd
@TimKoornstra
First automatic GitHub test action 🎉
753bf82 
Can be improved. Maybe with concurrency.
@TimKoornstra
Added VGSL spec
bafed90
@TimKoornstra
Improve logging and VGSLModelGenerator internal VGSL string
3d68b12
@TimKoornstra
Last dense layer output not hardcoded anymore
a785cac
@TimKoornstra
Dynamic last layer now also working for do_validate
c6835da
@TimKoornstra
Added small comment to test git
ea6e5d6
Revert last push
caf73c6
@Thelukepet
Testing adding bla bla in comment
75e5874
@Thelukepet
Extending comment
68e4e85
@TimKoornstra
Update model creation test to VGSLModelGenerator
425c557
@TimKoornstra
Merge branch 'model-refactor' of https://github.com/rvankoert/loghi-htr…
302428d 
… into model-refactor
@Thelukepet
Lstm/GRU/Bidirectional generator reworks, Dropout change for separati…
0640279 
…on, stride support in Conv2D generator, model_library changes
@Thelukepet
Merge remote-tracking branch 'origin/model-refactor' into model-refactor
73780e6
@Thelukepet
test_dropout_layer fix (formatting now caps + number which can be an …
3a11b03 
…arbitrary number, error will be raised if dropout >= 100 given)
@Thelukepet
Fixed tests according to layer generator reworks. Fixed resBlock nami…
d9d0158 
…ng issues
@TimKoornstra
Update unittest logging
5d3f050
@TimKoornstra
Merge branch 'model-refactor' of https://github.com/rvankoert/loghi-htr…
c3c5aaf 
… into model-refactor
@TimKoornstra
Update .gitignore
1977551
@Thelukepet
VGSL manual start
9af73b0
@TimKoornstra
Add docstrings to VGSLModelGenerator
e05ede1
@TimKoornstra
Merge branch 'model-refactor' of https://github.com/rvankoert/loghi-htr…
69512e0 
… into model-refactor
@TimKoornstra
Improved comments and error handling for VGSLModelGenerator
1722bfd
@MMaas3 MMaas3 requested review from rvankoert and removed request for MMaas3 September 22, 2023 08:22
@rvankoert rvankoert merged commit 453fb2e into master Sep 25, 2023
2 checks passed
@TimKoornstra TimKoornstra deleted the model-refactor branch September 25, 2023 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rvankoert rvankoert Awaiting requested review from rvankoert

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@TimKoornstra @rvankoert @Thelukepet