-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Loghi-HTR V2 #25
Merged
Merged
Loghi-HTR V2 #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oh yeah, it's all coming together
Next: another revision and split functions into files
…oved parts of visualize prep to separate vis_utils.py. Added error handling and docstrings
Things WILL break
…alents, docstrings, normalisation of variable names
…rements.txt, pruned vis_arg_parser, reintroduced main() functions, PdfMaker changes to structure
Main refactor & organize files into subfolders
…/loghi-htr into visualize-files-revamp
Data loader upgrade
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
V2
This combined pull request encompasses a range of enhancements and refactors across various aspects of the project. Below are the key changes and improvements grouped by their original pull request numbers.
Visualize files revamp #11
Main refactor & organize files into subfolders #13
main.py
, organizing functions into separate files within subfolders inside thesrc
directory.ResidualBlock
to incorporateReLU
activation by default.Improved LR schedule #14
LoghiLearningRateSchedule
class for more flexible learning rate adjustments.CustomLoghiCallback
.LoghiLearningRateSchedule
class and incorporated these tests into GitHub Actions.Improved args, and added config file #15
--config_file
argument.config.json
file structure for better organization.Config
class insrc/setup/config.py
for enhanced management of configuration settings.config.json
structures for backward compatibility.API v2 #17
Minor improvements #18
V1 DataGenerator and Data Augment Revamp on GPU (no unittest updates) #21
--visualize_augments
.QOL changes and code simplifications #22
Improve code quality #23
%
.with open()
statements.Data loader upgrade #24
DataLoader
andDataGenerator
classes, renaming and improving code documentation and clarity.Other changes include deprecated arguments in favor of new ones, updated
requirements.txt
, and added a recommended model to the model library.