fix: fallback for crypto.randomUUID on non-HTTPS connections#9
Open
dalager wants to merge 1 commit intorwliebs:mainfrom
Open
fix: fallback for crypto.randomUUID on non-HTTPS connections#9dalager wants to merge 1 commit intorwliebs:mainfrom
dalager wants to merge 1 commit intorwliebs:mainfrom
Conversation
crypto.randomUUID() requires a secure context (HTTPS or localhost) and throws when the app is accessed over plain HTTP on a LAN. Add a fallback using Date.now + Math.random for the chat message ID, which only serves as a React list key. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #7
Summary
crypto.randomUUID()requires a secure context (HTTPS or localhost) and throws when the app is accessed over plain HTTP on a LANDate.now+Math.random) for the chat message ID inleft-sidebar.tsx, which only serves as a React list keycrypto.randomUUID()calls are server-side (Node.js) and unaffectedNotes
This might be a blunt fallback, and either one would expect to run on https or delegate key-generation to an isolated function. So no hard feelings if rejecting. Just sharing my path to victory 😸
Test plan
http://192.168.x.x:3000)🤖 Generated with Claude Code