Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update simplified chinese translation #1425

Merged
merged 2 commits into from
Jul 19, 2024

Conversation

quan-goh
Copy link
Contributor

Added translations for new or needs-review strings.

Needs Review item:
For "Dismiss" there's multiple translation and I'm not entirely certain on the context so I kept it as Needs Review.

Currently I added it as "忽略" which means either disregard or ignore(as in ignoring the warning/alert/notification).

But if it should mean :

  1. cancel - as in cancelling an action, "取消“ should be used;
  2. close- as in closing the dialog/notification popup, "关闭" would be more appropriate.

@rxhanson
Copy link
Owner

Thanks! The scenario where this is being used is in a popup window with three options. In macOS 15, the window snapping built-in to macOS will conflict with Rectangle's, so the options are to turn off the macOS snapping, turn off the Rectangle snapping or dismiss the popup window without disabling either.

It seems like this might translate best to "disregard/ignore", but I could also see "close" as being acceptable. What do you think?

@quan-goh
Copy link
Contributor Author

I think in this case 忽略 as in "disregard/ignore" would fit better.

@rxhanson rxhanson merged commit 304ca2c into rxhanson:main Jul 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants