This repository has been archived by the owner on Dec 12, 2021. It is now read-only.
Placing conditions on optionally associated objects raises exceptions at rule match time #330
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Consider the classes:
The ability:
And the check:
In 1.6.4 this results in the exception
undefined method 'bar' for nil:NilClass
. This patch modifies the Rule#matches_conditions_hash? to return false for this case.Test included, and comments are welcome. Thanks!