feat: add release workflow #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryanccn
requested changes
Jul 19, 2023
| import { push } from "./stages/push.ts"; | ||
| import { getState, saveState } from "@actions/core"; | ||
|
|
||
| const isPost = !!getState("isPost"); |
There was a problem hiding this comment.
can typescript really automatically convert from string to boolean by itself? 🤔
this is because secrets aren't available for prs lol
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this adds a release workflow that creates a tag as small as possible - which is great for keeping the download for the action fast. you can find an example here
it also removes the need to continuously update
dist/, adopts standard versioning for the project, and requires 0 maintenance besides creating the release! the only drawback is that it combines index.ts and post.ts again :pwe can also see if the new nix cli fixes the issues in the test workflow...but idk /shrug
edit: and tests wont run on prs now since we need secrets, and prs don't have those :/