Skip to content

Commit

Permalink
Fix Star/Fork button sometimes not showing
Browse files Browse the repository at this point in the history
[why]
The Star and Fork buttons sometime show nicely, sometimes they are just
plain linked tect with no count and no icon and nothing.

[how]
The reason is not completely clear, sometimes it works and without any
change after a complete reload it does not work anymore.

The most likely candidate is the Github rate limit that we run into for
cross repo access. To avoid that we just copy the button script into our
repository. The rate limit will now not apply anymore.

But of course we will also not get any updates. That needs to be checked
from time to time manually - as with the Github actions.

Strange is already that the current script from github.io is version
2.27.0 while the latest release on the repo is 4.2.2. The date is the
same (Dec 2022).

Signed-off-by: Fini Jastrow <ulf.fini.jastrow@desy.de>
  • Loading branch information
Finii committed Oct 11, 2023
1 parent d60ae57 commit b28c8aa
Show file tree
Hide file tree
Showing 3 changed files with 9 additions and 3 deletions.
2 changes: 1 addition & 1 deletion _includes/header.html
Original file line number Diff line number Diff line change
Expand Up @@ -25,4 +25,4 @@
});
</script>
{% endif %}
</head>
</head>
4 changes: 2 additions & 2 deletions _includes/scripts.html
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
<script async defer src="https://buttons.github.io/buttons.js"></script>
<script src="buttons.js"></script>
<script src="site.js"></script>
<script type="application/ld+json">
{
Expand All @@ -15,4 +15,4 @@
"screenshot" : "https://www.nerdfonts.com/assets/img/nerd-fonts-powerline-extra-terminal.png",
"softwareVersion" : "{{ site.current_version }}"
}
</script>
</script>
6 changes: 6 additions & 0 deletions buttons.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit b28c8aa

Please sign in to comment.