Skip to content

Commit

Permalink
ci: make CI job fail when check-deps.sh script fails
Browse files Browse the repository at this point in the history
Previously the check-deps.sh would write information about unexpected
dependencies to stderr, but return exit code 0, so the error would be ignored
by CI. Now it will return code 1 and cause CI to fail if unexpected
dependencies are detected.
  • Loading branch information
ryanofsky committed Oct 1, 2024
1 parent d51edec commit fd38711
Showing 1 changed file with 3 additions and 0 deletions.
3 changes: 3 additions & 0 deletions contrib/devtools/check-deps.sh
Original file line number Diff line number Diff line change
Expand Up @@ -194,7 +194,10 @@ cd "$BUILD_DIR/src"
extract_symbols "$TEMP_DIR"
if check_libraries "$TEMP_DIR"; then
echo "Success! No unexpected dependencies were detected."
RET=0
else
echo >&2 "Error: Unexpected dependencies were detected. Check previous output."
RET=1
fi
rm -r "$TEMP_DIR"
exit $RET

0 comments on commit fd38711

Please sign in to comment.