Remove remaining references to gray() #220
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
vrugtehagel
commented
Jun 11, 2024
| @@ -111,7 +111,6 @@ | |||
| "fit-content": t.length + t.percentage, | |||
| "format": [t.string], | |||
| "frames": t.integer, | |||
| "gray": t.number + t.percentage, | |||
There was a problem hiding this comment.
This reference might not actually be problematic in terms of autocompletions, but it should be removed regardless since the gray() function no longer exists
vrugtehagel
commented
Jun 11, 2024
| @@ -393,7 +393,6 @@ | |||
| device_gray, | |||
| device_nchannel, | |||
| device_rgb, | |||
| gray, | |||
There was a problem hiding this comment.
The issue is most likely that I removed the gray definition here but not this reference to it - my bad 😬
argyleink
approved these changes
Jun 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Third followup to #212 and #215 - looks like I missed some references that are now causing issues.
Hope this resolves #198 (and #216)