Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use ruff for formatting #1980

Merged
merged 3 commits into from
Oct 27, 2024
Merged

Use ruff for formatting #1980

merged 3 commits into from
Oct 27, 2024

Conversation

rytilahti
Copy link
Owner

Also, simplify the CI pipeline to use pre-commit instead of individual checks

Also, simplify the CI pipeline to use pre-commit instead of individual checks
@@ -81,7 +81,9 @@
keystring = "00000000000000000000000000000000"
key = bytes.fromhex(keystring)
cipher = Cipher(
algorithms.AES(key), modes.ECB(), backend=default_backend() # nosec
algorithms.AES(key),
modes.ECB(),

Check failure

Code scanning / SonarCloud

Encryption algorithms should be used with secure mode and padding scheme

<!--SONAR_ISSUE_KEY:AZLLaZ-o53x7xtMCc7Gc-->Use secure mode and padding scheme. <p>See more on <a href="https://sonarcloud.io/project/issues?id=rytilahti_python-miio&issues=AZLLaZ-o53x7xtMCc7Gc&open=AZLLaZ-o53x7xtMCc7Gc&pullRequest=1980">SonarCloud</a></p>
Copy link

codecov bot commented Oct 27, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 82.23%. Comparing base (2dc6faf) to head (9e4cf2c).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
miio/push_server/server.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1980   +/-   ##
=======================================
  Coverage   82.23%   82.23%           
=======================================
  Files         197      197           
  Lines       19127    19127           
  Branches     1050     1050           
=======================================
  Hits        15729    15729           
  Misses       3220     3220           
  Partials      178      178           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rytilahti rytilahti merged commit ff46761 into master Oct 27, 2024
19 of 25 checks passed
@rytilahti rytilahti deleted the janitor/ruff_format branch October 27, 2024 00:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant