Add unique_identifier property to miot properties, actions, and events #1984
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows descriptors to have device-unique identifiers, the format is '<normalized_name>_<siid>_<id>'. This also changes 'id' of the descriptors to use this identifier in-place of a plain name from the description.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1984 +/- ##
==========================================
+ Coverage 82.23% 82.26% +0.02%
==========================================
Files 197 197
Lines 19127 19139 +12
Branches 1050 1050
==========================================
+ Hits 15729 15744 +15
+ Misses 3220 3218 -2
+ Partials 178 177 -1 ☔ View full report in Codecov by Sentry. |
|
The CI fails are irrelevant for this change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows descriptors to have device-unique identifiers, the format is '<normalized_name>'.
This also changes 'id' of the descriptors to use this identifier in-place of a plain name from the description.