Merge pull request #274 from ryukzak/constant-folding-problem

Add issue detail on constant folding
ryukzak · Jan 21, 2024 · 84acffd · 84acffd
2 parents b91a783 + b235f5f
commit 84acffd
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 5 deletions.
diff --git a/test/NITTA/Model/ProcessorUnits/Tests/DSL/Tests.hs b/test/NITTA/Model/ProcessorUnits/Tests/DSL/Tests.hs
@@ -204,8 +204,11 @@ tests =
                     , constant 2 ["!2#0"]
                     , constant 1 ["!1#0"]
                     ]
+                    -- FIXME: https://github.com/ryukzak/nitta/issues/196
+                    -- should be:
+                    -- [ constant 3 ["_0#d"] ]
                     [ constant 3 ["_0#d"]
-                    , constant 2 ["!2#0"] -- FIXME: Do we actually need this?
+                    , constant 2 ["!2#0"]
                     , constant 1 ["!1#0"]
                     ]
                     >>= \r -> assertRefactor r

diff --git a/web/src/components/SubforestTables/Columns.tsx b/web/src/components/SubforestTables/Columns.tsx
@@ -218,12 +218,10 @@ export function showBreakLoop(decision: BreakLoop): ReactElement {
 export function showConstantFolding(d: ConstantFolding): ReactElement {
   return (
     <div>
-      {d.cRefOld.map((e: FView) => e.fvFun).join("\n")}
-      <br />
+      {d.cRefOld.map((e: FView) => <> {e.fvFun} <br/></>)}
       <Icon.ArrowDown />
       <br />
-      {d.cRefNew.map((e: FView) => e.fvFun).join(", ")}
-      <br />
+      {d.cRefNew.map((e: FView) => <> {e.fvFun} <br/></>)}
     </div>
   );
 }