Fix: Updates failed for Apps with mutiple InstallTypes

rzander · Nov 2, 2019 · a1e9001 · a1e9001
1 parent d42cec6
commit a1e9001
Show file tree

Hide file tree

Showing 3 changed files with 21 additions and 6 deletions.
diff --git a/RZ.Base/RZUpdate.cs b/RZ.Base/RZUpdate.cs
@@ -71,11 +71,26 @@ public SWUpdate CheckForUpdate(string ProductName, string Version, string Manufa
                                 if (string.IsNullOrEmpty(SW.PSPreReq))
                                     SW.PSPreReq = "$true; ";
 
-                                //Check PreReq for all Installation-types of the Software
-                                if ((bool)SWUpdate._RunPS(SWCheck.PSPreReq)[0].BaseObject)
+                                var pRes = SWUpdate._RunPS(SWCheck.PSPreReq);
+                                if (pRes.Count > 0)
                                 {
-                                    SoftwareUpdate = new SWUpdate(SWCheck);
-                                    return SoftwareUpdate;
+                                    try
+                                    {
+                                        //Check PreReq for all Installation-types of the Software
+                                        if ((bool)pRes[0].BaseObject)
+                                        {
+                                            SoftwareUpdate = new SWUpdate(SWCheck);
+                                            return SoftwareUpdate;
+                                        }
+                                    }
+                                    catch
+                                    {
+                                        continue;
+                                    }
+                                }
+                                else
+                                {
+                                    continue;
                                 }
                             }
                         }

diff --git a/RZUpdate/Properties/AssemblyInfo.cs b/RZUpdate/Properties/AssemblyInfo.cs
@@ -33,4 +33,4 @@
 // by using the '*' as shown below:
 // [assembly: AssemblyVersion("1.0.*")]
 [assembly: AssemblyVersion("1.7.1.*")]
-[assembly: AssemblyFileVersion("1.7.1.1")]
+[assembly: AssemblyFileVersion("1.7.1.2")]
diff --git a/RZUpdateTest/UnitTest1.cs b/RZUpdateTest/UnitTest1.cs
@@ -13,7 +13,7 @@ public void TestMethodDownloadUpdate()
         {
             Console.WriteLine("Check Update for SCCMCliCtr 1.0.3.9...");
             RZUpdater oRZSW = new RZUpdater();
-            var oUpdate = oRZSW.CheckForUpdate("Client Center for Configuration Manager", "1.0.3.9", "Zander Tools");
+            var oUpdate = oRZSW.CheckForUpdate("Adobe Acrobat Reader DC MUI", "19.021.20048", "Adobe Systems Incorporated");
             Console.WriteLine("found Version:" + oRZSW.SoftwareUpdate.SW.ProductVersion);
             Assert.IsNotNull(oUpdate, "Update detected successfully.");
             Assert.IsNotNull(oUpdate.SW.ContentID, "Update conatins ContentID");