Add Echo router extractor and method parser.#17
Add Echo router extractor and method parser.#17piotrekmonko wants to merge 3 commits intos-mang:masterfrom
Conversation
s-mang
left a comment
s-mang
left a comment
There was a problem hiding this comment.
Hey! Thanks for the pull! I have some initial comments right off the bat but I'll review in more detail later today or tomorrow.
Cheers -
|
|
||
| Generate documentation for your REST/HTTP API from your Go unit tests - a simple addition to Go's testing package. | ||
|
|
||
| This fork adds `MakeEchoRouterExtractor` to extract query params from labstack.Echo server |
| @@ -1,4 +1,79 @@ | |||
| github.com/davecgh/go-spew v1.1.0/go.mod h1:J7Y8YcW2NihsgmVo/mv3lAwl/skON4iLHjSsI+c5H38= | |||
There was a problem hiding this comment.
go.sum got a bit out of control here! can you clean this up?
There was a problem hiding this comment.
oh my bad, i guess echo just imports a ton of external libraries huh.
There was a problem hiding this comment.
That's correct. Lots of useless dependencies. I'll try to "interfacerize" if you'd like that?
| fn.Doc = strings.Replace(fn.Doc, "\t", " ", -1) | ||
| funcsMap["("+fn.Recv+")"+fn.Name] = fn | ||
| } | ||
| } |
There was a problem hiding this comment.
I tested this locally and I get the same doc generated for a method handler with and without your code change.
Can you add an example in examples/widgets/* or foos/* to demonstrate that the change works?
| @@ -0,0 +1,26 @@ | |||
| package vars | |||
|
|
|||
There was a problem hiding this comment.
I am hesitant to add this change because of the enormous amount of dependencies that echo brings in.
I would prefer to see this URL Var extractor added as documentation in the Readme.
2 participants
No description provided.