Skip to content

[FEATURE] 리팩터링 챕터 8 작성 완료 #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
s3ich4n merged 36 commits into from
May 3, 2025
Merged

[FEATURE] 리팩터링 챕터 8 작성 완료 #25

s3ich4n merged 36 commits into from
May 3, 2025

Conversation

@s3ich4n
Copy link
Owner

@s3ich4n s3ich4n commented Apr 21, 2025

Summary

리팩터링 챕터 9 정리 완료 (resolves #16)

Changes

  • 책의 내용 1회독
  • 테스트코드 추가
  • 캡슐화의 다른 언어에 대한 명확성과, 파이썬의 특징 소개

PR Checklists

PR이 다음 요구 사항을 충족하는지 확인하세요.

  • 변경 사항에 대한 테스트를 했습니다(버그 수정/기능에 대한 테스트).

@s3ich4n s3ich4n added documentation Improvements or additions to documentation refactor Refactored labels Apr 21, 2025
@s3ich4n s3ich4n self-assigned this Apr 21, 2025
@s3ich4n
Copy link
Owner Author

s3ich4n commented Apr 21, 2025

📝 Test & Coverage Report

Metric Value
✅ Passed 321
❌ Failed 0
⏩ Skipped 0
⏱️ Time 0.35s
📊 Line Coverage 98.47%

s3ich4n added 14 commits April 22, 2025 12:27
@s3ich4n
refactor(chapter08): rename distance calculation function and update …
db03126 
…track_summary
@s3ich4n
feat(chapter08): add distance calculation and track summary functions
c7afbde
@s3ich4n
feat(chapter08): implement Account and AccountType classes with bank …
852ff94 
…charge calculations and tests
@s3ich4n
feat(chapter08): implement overdraft_charge method in AccountType and…
632f282 
… refactor Account class
@s3ich4n
feat(chapter08): add Customer and CustomerContract classes with tests…
c527f4d 
… for initialization, discount application, and preferred status
@s3ich4n
refactor(chapter08): update Customer class to use set_discount_rate m…
c14c398 
…ethod for setting discount rate
@s3ich4n
refactor(chapter08): move discount_rate field to CustomerContract for…
aed4196 
… better encapsulation
@s3ich4n
refactor(chapter08): rename case02.py to case02_1.py for clarity in m…
9da1f2c 
…odule structure
@s3ich4n
feat(chapter08): add Account and AccountType classes with tests for i…
bf5017e 
…nitialization and interest rate property
@s3ich4n
refactor(chapter08): encapsulate account number and account type fiel…
d068807 
…ds in Account class
@s3ich4n
feat(chapter08): add rendering functions for person and photo with tests
753ef68
@s3ich4n
refactor(chapter08): extract photo rendering logic into zznew functio…
19f16d9 
…n for improved readability
@s3ich4n
refactor(chapter08): replace emit_photo_data with zznew for photo dat…
8df8cc7 
…a rendering
@s3ich4n
refactor(chapter08): rename zznew to emit_photo_data for clarity in p…
0af34b1 
…hoto rendering
@s3ich4n
Copy link
Owner Author

s3ich4n commented Apr 29, 2025

📝 Test & Coverage Report

Metric Value
✅ Passed 339
❌ Failed 0
⏩ Skipped 0
⏱️ Time 0.38s
📊 Line Coverage 98.51%

s3ich4n added 9 commits April 30, 2025 12:54
@s3ich4n
feat(chapter08): implement photo and person classes with rendering fu…
b4514c2 
…nctions
@s3ich4n
refactor(chapter08): move location rendering to separate zztmp functi…
dfe345e 
…on for better structure
@s3ich4n
refactor(chapter08): replace emit_photo_data with zztmp for photo ren…
255a012 
…dering and add location display
@s3ich4n
refactor(chapter08): replace zztmp with emit_photo_data for photo ren…
e4feab2 
…dering
@s3ich4n
docs(chapter08): update examples for refactoring photo rendering with…
e88eb4c 
… location handling
@s3ich4n
docs(chapter08): add README for refactoring inline code to function c…
7fd2269 
…alls
@s3ich4n
docs(chapter08): add README for sliding statements refactoring technique
e4b66e5
@s3ich4n
feat(chapter08): add Person class and calculate_stats function with t…
9783c98 
…ests
@s3ich4n
fix(chapter08): correct indentation for salary calculation loop
37886ec
s3ich4n added 11 commits May 3, 2025 18:19
@s3ich4n
fix(chapter08): optimize calculate_stats function by rearranging sala…
c976522 
…ry calculation and youngest age logic
@s3ich4n
refactor(chapter08): separate youngest_age and total_salary functions…
b7937db 
… from calculate_stats
@s3ich4n
refactor(chapter08): simplify youngest_age and total_salary functions…
5791fff 
… using generator expressions
@s3ich4n
docs(chapter08): update README to clarify refactoring and optimizatio…
7b3f5ec 
…n concepts
@s3ich4n
feat(chapter08): add data acquisition function and test cases for Ind…
e26ef04 
…ian cities
@s3ich4n
refactor(chapter08): streamline acquire_data function using list comp…
25008d9 
…rehension
@s3ich4n
docs(chapter08): enhance README with Java example for data acquisitio…
6057a73 
…n using streams
@s3ich4n
docs(chapter08): add README section on removing dead code with examples
f386037
@s3ich4n
docs(chapter08): remove redundant instructions from README for clarity
849d2de
@s3ich4n
docs(chapter08): marked chapter 8 as complete
ea6be67
@s3ich4n
fix(chapter04): correct date calculations for photo entries
80fcf8c
@s3ich4n
Copy link
Owner Author

s3ich4n commented May 3, 2025

📝 Test & Coverage Report

Metric Value
✅ Passed 349
❌ Failed 0
⏩ Skipped 0
⏱️ Time 0.38s
📊 Line Coverage 98.56%

@s3ich4n s3ich4n marked this pull request as ready for review May 3, 2025 10:08
@s3ich4n s3ich4n merged commit ec85742 into main May 3, 2025
1 check passed
@s3ich4n s3ich4n deleted the chapter8 branch May 3, 2025 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@s3ich4n s3ich4n

Labels

documentation Improvements or additions to documentation refactor Refactored

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[FEATURE] 리팩터링 챕터 8

1 participant

@s3ich4n