fix(sig_v2): add 14 missing sub-resources to INCLUDED_QUERY#517
Merged
Conversation
Co-authored-by: Nugine <30099658+Nugine@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Split V2 sub-resource list changes into new PR
fix(sig_v2): add 14 missing sub-resources to INCLUDED_QUERY
Feb 26, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes V2 signature verification by adding 14 missing sub-resources to the INCLUDED_QUERY constant, ensuring it matches botocore's QSAOfInterest list. This resolves signature mismatches that previously occurred when operations like PutBucketCors, PutBucketTagging, and PutBucketReplication were signed with botocore using V2 signatures.
Changes:
- Adds 14 sub-resources to
INCLUDED_QUERYin alphabetical order:accelerate,analytics,cors,defaultObjectAcl,inventory,metrics,object-lock,replication,restore,select,select-type,storageClass,tagging, andtorrent
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
V2 signature verification was missing 14 sub-resources from
INCLUDED_QUERY, causing signature mismatches for operations likePutBucketCors,PutBucketTagging, andPutBucketReplicationwhen signed with botocore.Changes
crates/s3s/src/sig_v2/methods.rs: Adds the following entries toINCLUDED_QUERYto match botocore'sQSAOfInterest:accelerate,analytics,cors,defaultObjectAcl,inventory,metrics,object-lock,replication,restore,select,select-type,storageClass,tagging,torrentThe list remains alphabetically sorted, enforced by the existing
sortedunit test.🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.