fix: allow hyphens and spaces in theme generator theme name#4469
Open
Parth10P wants to merge 1 commit intosaadeghi:masterfrom
Open
fix: allow hyphens and spaces in theme generator theme name#4469Parth10P wants to merge 1 commit intosaadeghi:masterfrom
Parth10P wants to merge 1 commit intosaadeghi:masterfrom
Conversation
Author
|
@saadeghi is anything need's to be change or edits..? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4387.
The theme generator silently discards all changes when the theme name contains a hyphen (e.g. my-theme) or a space (e.g. cringe classic). This is caused by an overly restrictive regex in
themeGeneratorValidation.jsthat only accepts[a-z]characters.changes made
themeGeneratorValidation.jsto allow lowercase letters, digits, spaces, and hyphens (while continuing to prevent them at the very start or end of the name)..trim()to the validation pipeline so that trailing spaces typed by users don't temporarily break the validator or pollute the generated output.Screen.Recording.2026-03-18.at.7.mp4