Sourcery refactored master branch #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
| for i in range(num_of_enemies): | ||
| for _ in range(num_of_enemies): |
There was a problem hiding this comment.
Lines 40-40 refactored with the following changes:
- Replace unused for index with underscore (
for-index-underscore)
| score = font.render("Score :" + str(score_value), True, (255, 255, 255)) | ||
| score = font.render(f"Score :{str(score_value)}", True, (255, 255, 255)) |
There was a problem hiding this comment.
Function show_score refactored with the following changes:
- Use f-string instead of string concatenation (
use-fstring-for-concatenation)
| if distance < 27: | ||
| return True | ||
| else: | ||
| return False | ||
| return distance < 27 |
There was a problem hiding this comment.
Function isCollision refactored with the following changes:
- Simplify boolean if expression (
boolean-if-exp-identity) - Remove unnecessary casts to int, str, float or bool (
remove-unnecessary-cast) - Replace if statement with if expression (
assign-if-exp)
Comment on lines
-119
to
+131
| if event.key == pg.K_KP_ENTER: | ||
| if bullet_state is 'ready': | ||
| # Get the current x cordinate of the spaceship | ||
| bulletX = playerX | ||
| fire_bullet(bulletX, bulletY) | ||
| if event.key == pg.K_SPACE: | ||
| if bullet_state is 'ready': | ||
| # Get the current x cordinate of the spaceship | ||
| bullet_sound = mixer.Sound("laser.wav") | ||
| bullet_sound.set_volume(0.2) | ||
| bullet_sound.play() | ||
| bulletX = playerX | ||
| fire_bullet(bulletX, bulletY) | ||
| if event.key == pg.KMOD_ALT or event.key == pg.K_F4: | ||
| if event.key == pg.K_KP_ENTER and bullet_state is 'ready': | ||
| # Get the current x cordinate of the spaceship | ||
| bulletX = playerX | ||
| fire_bullet(bulletX, bulletY) | ||
| if event.key == pg.K_SPACE and bullet_state is 'ready': | ||
| # Get the current x cordinate of the spaceship | ||
| bullet_sound = mixer.Sound("laser.wav") | ||
| bullet_sound.set_volume(0.2) | ||
| bullet_sound.play() | ||
| bulletX = playerX | ||
| fire_bullet(bulletX, bulletY) | ||
| if event.key in [pg.KMOD_ALT, pg.K_F4]: | ||
| running = False | ||
|
|
||
| if event.type == pg.KEYUP: | ||
| if event.key == pg.K_LEFT or event.key == pg.K_RIGHT: | ||
| playerX_change = 0 | ||
| if event.type == pg.KEYUP and event.key in [pg.K_LEFT, pg.K_RIGHT]: | ||
| playerX_change = 0 |
There was a problem hiding this comment.
Lines 119-170 refactored with the following changes:
- Merge nested if conditions (
merge-nested-ifs) - Replace multiple comparisons of same variable with
inoperator (merge-comparisons) - Use named expression to simplify assignment and conditional (
use-named-expression)
This removes the following comments ( why? ):
# Collision
Sourcery Code Quality Report✅ Merging this PR will increase code quality in the affected files by 1.58%.
Here are some functions in these files that still need a tune-up:
Legend and ExplanationThe emojis denote the absolute quality of the code:
The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request. Please see our documentation here for details on how these metrics are calculated. We are actively working on this report - lots more documentation and extra metrics to come! Help us improve this quality report! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Branch
masterrefactored by Sourcery.If you're happy with these changes, merge this Pull Request using the Squash and merge strategy.
See our documentation here.
Run Sourcery locally
Reduce the feedback loop during development by using the Sourcery editor plugin:
Review changes via command line
To manually merge these changes, make sure you're on the
masterbranch, then run:Help us improve this pull request!