feat: API improvements #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was
linked to
issues
Nov 27, 2023
razgraf
approved these changes
Nov 30, 2023
There was a problem hiding this comment.
Great work @gavriliumircea! I've left my review on Slack as it was mostly about small typos and questions re. implementation. LGTM!
|
I will review this during the weekend, but if you urgently need it on |
chore: improve wording in comments docs: minor wording improvements in README style: improve formatting
PaulRBerg
approved these changes
Dec 6, 2023
There was a problem hiding this comment.
I only had a cursory look at the tests, but this PR generally looks good to me, great job @gavriliumircea.
Might be interesting to explore whether Branching Tree Technique can be used in Rust!
|
@gavriliumircea feel free to merge this once you review the comments above |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr aims to implement some improvements for the merkle api.
Bellow you can find a list with the improvements:
merkle-apiservice #3)