Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add description (show, add, modify) #238

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

psethwick
Copy link

adds --description option to add and modify commands description listed in show command

let me know if there are any issues you'd like me to address, I'm pretty fresh on go

addresses #185

adds --description option to add and modify commands
description listed in `show` command
@HacDan
Copy link
Contributor

HacDan commented Aug 6, 2023

Seems all functional.

My only issue is no short command like -d. I know -d is taken by -date but it would be nice to have a shorter way of adding a description. These are described in Aliases here:

Aliases: []string{},

I, unfortunately, do not have any suggestions, but that would be the only fault I see. Rest looks good to me! I don't think not having an alias is enough to hold this PR back, though!

@psethwick
Copy link
Author

psethwick commented Aug 8, 2023

I did have -d in there to start with, but the conflict with -date stopped it compiling (actually I don't remember, might have been runtime).
Suggestions, in no real order:

  • de
  • D
  • e

@HacDan
Copy link
Contributor

HacDan commented Aug 8, 2023

I think -D could work, but I'm open to other options as well. I mainly use this from a scripting standpoint, so not a huge effect on my personal use, I only brought it up for consistency with the other flags.

EDIT: Clearly missed the shift key there.

@kenliu would be the one making the call here I believe.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants