naming convention fixes

sadabnepal · May 28, 2024 · ae2a4f6 · ae2a4f6
1 parent 495ad68
commit ae2a4f6
Show file tree

Hide file tree

Showing 4 changed files with 17 additions and 18 deletions.
diff --git a/tests/data/faker.ts b/tests/data/faker.ts
@@ -1,7 +1,7 @@
 import { faker } from '@faker-js/faker';
-import { IUser, IUserOmittedID } from 'types/users';
+import { IUser, IUserCreateRequest } from 'types/users';
 
-export const createUserData: IUserOmittedID = {
+export const createUserData: IUserCreateRequest = {
     name: faker.person.fullName(),
     gender: faker.person.sexType(),
     email: faker.internet.email(),

diff --git a/tests/payload/mutation.ts b/tests/payload/mutation.ts
@@ -1,7 +1,7 @@
-import { IUser, IUserOmittedID } from 'types/users';
+import { IUser, IUserCreateRequest } from 'types/users';
 import { userFragments, userResponseFields } from './fragments';
 
-export const createUserPayload = (data: IUserOmittedID) => {
+export const createUserPayload = (data: IUserCreateRequest) => {
     return `
     ${userFragments}
     mutation {

diff --git a/tests/specs/goRestTests.ts b/tests/specs/goRestTests.ts
@@ -5,7 +5,7 @@ import { mutateGraphQl, queryGraphQl } from 'helper/apiUtils';
 import { queryUsers } from 'payload/directives';
 import { createUserPayload, deleteUserPayload, updateUserPayload } from 'payload/mutation';
 import { queryAllUserPayload, queryUserByIdPayload } from 'payload/queries';
-import { INonExistingUserError, IUser, IUserCreate, IUserDelete, IUserUpdate, IUsers } from 'types/users';
+import { INonExistingUserError, IUser, IUserCreateResponse, IUserDeleteResponse, IUserUpdateResponse, IUsers } from 'types/users';
 config();
 
 const TOKEN = process.env.GO_RES_USER_TOKEN;
@@ -41,7 +41,7 @@ describe('go rest graphql tests', () => {
         const response = await mutateGraphQl(TOKEN, createUserPayload(createRandomUser));
         expect(response.statusCode).equal(200);
 
-        const responseData: IUserCreate = response.body.data;
+        const responseData: IUserCreateResponse = response.body.data;
 
         userId = responseData.createUser.user.id;
         console.log('----------------------------');
@@ -84,7 +84,7 @@ describe('go rest graphql tests', () => {
 
         expect(response.body.data).not.undefined;
 
-        const responseData: IUserUpdate = response.body.data;
+        const responseData: IUserUpdateResponse = response.body.data;
 
         console.log('----------------------------');
         console.log('updated user => id: ', userId);
@@ -105,7 +105,7 @@ describe('go rest graphql tests', () => {
 
         expect(response.body.data).not.undefined;
 
-        const responseData: IUserDelete = response.body.data;
+        const responseData: IUserDeleteResponse = response.body.data;
 
         console.log('----------------------------');
         console.log('deleted user => id: ', userId);

diff --git a/tests/types/users.ts b/tests/types/users.ts
@@ -1,15 +1,12 @@
-export type genderType = 'male' | 'female';
-
-export type statusType = 'active' | 'inactive';
-
-export interface IUserOmittedID extends Omit<IUser, 'id'> { }
+type Gender = 'male' | 'female';
+type Status = 'active' | 'inactive';
 
 export interface IUser {
     id: number;
     name: string;
     email: string;
-    gender: genderType;
-    status: statusType;
+    gender: Gender;
+    status: Status;
 }
 
 export interface IUsers {
@@ -19,19 +16,21 @@ export interface IUsers {
     }
 }
 
-export interface IUserCreate {
+export interface IUserCreateRequest extends Omit<IUser, 'id'> { }
+
+export interface IUserCreateResponse {
     createUser: {
         user: IUser
     }
 }
 
-export interface IUserUpdate {
+export interface IUserUpdateResponse {
     updateUser: {
         user: IUser
     }
 }
 
-export interface IUserDelete {
+export interface IUserDeleteResponse {
     deleteUser: {
         user: IUser
     }