Conversation
…ining either to avoid reimplementing ConcatenatedCollection a bunch of times.
…graphs together without making a copy. Also along with this change includes: 1. A collection which concatenates two heterogeneous collections, so long as their element types are identical. 2. DefaultInitializable conformances for a variety of fixed-width numerical types. 3. An implementation of `Either` which is used to implement `UnionEdgeGraph` as well as `ConcatenatedCollection`. 4. Tests for the above. Note: The `UnionEdgeGraph` demonstrates why an `Either` type is necessary (assuming we want to avoid duplicating the implementation of ConcatenatedCollection across both the `VertexEdgeCollection` and `VertexInEdgeCollection` types).
Co-authored-by: Dave Abrahams <dabrahams@google.com>
Co-authored-by: Dave Abrahams <dabrahams@google.com>
…collection conformances.
saeta
approved these changes
Aug 12, 2020
Owner
saeta
left a comment
saeta
left a comment
There was a problem hiding this comment.
Sorry for not pushing this through. Thanks for taking it over the finish line.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This work is based on #84