Skip to content

Comments

Fix #filePath mis-threading.#111

Open
dabrahams wants to merge 3 commits intomainfrom
fix-filePath-misthreading
Open

Fix #filePath mis-threading.#111
dabrahams wants to merge 3 commits intomainfrom
fix-filePath-misthreading

Conversation

@dabrahams
Copy link
Collaborator

No description provided.

@dabrahams
Copy link
Collaborator Author

@saeta Tester seems to be using an outdated compiler?

@saeta
Copy link
Owner

saeta commented Aug 17, 2020

From console output, the compiler version provided by Ubuntu / GitHub on Linux is:

Run swift --version
Swift version 5.2.5 (swift-5.2.5-RELEASE)
Target: x86_64-unknown-linux-gnu

And for macOS it's:

Run swift --version
Apple Swift version 5.2.4 (swiftlang-1103.0.32.9 clang-1103.0.32.53)
Target: x86_64-apple-darwin19.6.0

So, it seems like we need to wait for Swiftc 5.3 to land in GitHub's standard CI environments before merging this, right?

@dabrahams
Copy link
Collaborator Author

dabrahams commented Aug 17, 2020

So, it seems like we need to wait for Swiftc 5.3 to land in GitHub's standard CI environments before merging this, right?

Ah guess so?

@MaxDesiatov
Copy link

Ubuntu 20.04 does have Swift 5.3, and macOS images have latest Xcode too, it's enough to run something like sudo xcode-select --switch /Applications/Xcode_12.1.app/Contents/Developer within your action to enable it.

@dabrahams dabrahams force-pushed the fix-filePath-misthreading branch from 80c13e8 to c539543 Compare October 22, 2020 16:37
@dabrahams
Copy link
Collaborator Author

@saeta Either way, PTAL since I've now made the PR compatible with all versions of Swift.

Note: I did try factoring out common code on one file and it was not an obvious improvement. We could use gyb…

@texasmichelle texasmichelle changed the base branch from master to main December 8, 2020 01:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants