Skip to content

Comments

Rewrite Deque#118

Draft
saeta wants to merge 2 commits intomainfrom
deque
Draft

Rewrite Deque#118
saeta wants to merge 2 commits intomainfrom
deque

Conversation

@saeta
Copy link
Owner

@saeta saeta commented Sep 8, 2020

The previous implementation did not appropriately conform to the
standard Collection protocols, and additionally had extra reference
counting operations. This new Deque implementation is designed to be
more flexible and easy to use without sacrificing performance.

This is step 1 in rewriting Deque to be more general and flexible.
The previous implementation did not appropriately conform to the
standard Collection protocols, and additionally had extra reference
counting operations. This new Deque implementation is designed to be
more flexible and easy to use without sacrificing performance.
@saeta saeta requested a review from dabrahams September 8, 2020 04:08
@dabrahams
Copy link
Collaborator

@saeta You left a review request yet it's still a draft. Should I review or hold off?

@saeta
Copy link
Owner Author

saeta commented Sep 9, 2020

@dabrahams Thanks for asking! I have a number of things I want to add (e.g. RandomAccessCollection conformance, MutableCollection conformance, etc), but the basics of the new Deque implementation should be there, and I'd definitely appreciate a review of those. (i.e. A "30%" review.)

@saeta
Copy link
Owner Author

saeta commented Sep 9, 2020

One question for you I have is: I'm not sure how to satisfy both the requirements for Index on BidirectionalCollection (in particular, comparison between Indexes) as well as the design goal of having stable Indexes. Happy to chat further if that's helpful.

@texasmichelle texasmichelle changed the base branch from master to main December 8, 2020 01:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants