Conversation
This is step 1 in rewriting Deque to be more general and flexible.
The previous implementation did not appropriately conform to the standard Collection protocols, and additionally had extra reference counting operations. This new Deque implementation is designed to be more flexible and easy to use without sacrificing performance.
Collaborator
|
@saeta You left a review request yet it's still a draft. Should I review or hold off? |
Owner
Author
|
@dabrahams Thanks for asking! I have a number of things I want to add (e.g. |
Owner
Author
|
One question for you I have is: I'm not sure how to satisfy both the requirements for |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The previous implementation did not appropriately conform to the
standard Collection protocols, and additionally had extra reference
counting operations. This new Deque implementation is designed to be
more flexible and easy to use without sacrificing performance.