Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add IPortfolioRepository domain and implementation #2260

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

iamacook
Copy link
Member

Summary

This adds the domain layer for the forthcoming portfolio feature.

A new IPortfolioRepositry, including a method to get the portfolio for a specified address. The implementation of which fetches a portfolio and validates it according to the Octav-based PortfolioSchema.

Changes

  • Add IPortfolioRepositry with implementation
  • Implement and test PortfolioSchema
  • Add builders for Portfolio and constituent entities

@iamacook iamacook self-assigned this Jan 15, 2025
@iamacook iamacook requested a review from a team as a code owner January 15, 2025 08:01
@iamacook iamacook force-pushed the portfolio-api-datasource branch from 2925044 to e1f807a Compare January 15, 2025 08:02
Base automatically changed from portfolio-api-datasource to main January 15, 2025 08:03
@iamacook iamacook marked this pull request as draft January 16, 2025 11:09
@iamacook iamacook added the Blocked Issue is blocked by a different issue label Jan 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Blocked Issue is blocked by a different issue
Projects
Status: Todo
Development

Successfully merging this pull request may close these issues.

1 participant