Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update address for chain id 300 #899

Merged
merged 1 commit into from
Dec 4, 2024
Merged

Update address for chain id 300 #899

merged 1 commit into from
Dec 4, 2024

Conversation

akshay-ap
Copy link
Member

Fixes: #686
Fixes: safe-global/safe-core-sdk#1044

Changes in PR:

  • Fixes addresses for chain id 300 which is zksync testnet.

@akshay-ap akshay-ap requested review from gjeanmart and a team as code owners December 4, 2024 12:20
@akshay-ap akshay-ap self-assigned this Dec 4, 2024
@akshay-ap akshay-ap merged commit 52fe9fa into main Dec 4, 2024
1 of 2 checks passed
@akshay-ap akshay-ap deleted the fix-zksync-testnet-addresses branch December 4, 2024 13:39
@dasanra dasanra mentioned this pull request Jan 20, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmv08 mmv08 mmv08 approved these changes

@gjeanmart gjeanmart Awaiting requested review from gjeanmart gjeanmart is a code owner

@nlordell nlordell Awaiting requested review from nlordell nlordell is a code owner automatically assigned from safe-global/safe-protocol

@remedcu remedcu Awaiting requested review from remedcu remedcu is a code owner automatically assigned from safe-global/safe-protocol

Assignees

@akshay-ap akshay-ap

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Wrong chain-id for zksync testnet Incorrect deployment addresses listed for zkSync Sepolia (chainid 300)
2 participants
@akshay-ap @mmv08