Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Odyssey testnet integration #28

Closed
wants to merge 3 commits into from
Closed

Odyssey testnet integration #28

wants to merge 3 commits into from

Conversation

IntegralTeam
Copy link

@IntegralTeam
Update safe-4337-module.json
188c6f9 
add safe4337module address
@IntegralTeam
Update safe-module-setup.json
47f803a 
add safemodulesetup address
@IntegralTeam
Update allowance-module.json
72ac5bd 
add address to allowancemodule
@IntegralTeam IntegralTeam requested a review from a team as a code owner June 20, 2024 06:30
@IntegralTeam IntegralTeam requested review from nlordell, akshay-ap, mmv08 and remedcu and removed request for a team June 20, 2024 06:30
@mmv08
Copy link
Member

mmv08 commented Jun 20, 2024

Please make sure that the addresses correspond to the expected counterfactual addresses.

And do not remove other entries from files. Feel free to create a new PR.

@mmv08 mmv08 closed this Jun 20, 2024
@IntegralTeam
Copy link
Author

@mmv08 Thank you for the feedback! We asked about addresses several days ago on stackexchange https://ethereum.stackexchange.com/questions/164157/safe-4337-module-cannot-deploy-deterministic-deployment-proxy-due-to-low-gas-pr

Do you mean that we must use deterministic-deployment-proxy in order to keep the same proxy addresses?

@mmv08
Copy link
Member

mmv08 commented Jun 20, 2024

@mmv08 Thank you for the feedback! We asked about addresses several days ago on stackexchange https://ethereum.stackexchange.com/questions/164157/safe-4337-module-cannot-deploy-deterministic-deployment-proxy-due-to-low-gas-pr

Do you mean that we must use deterministic-deployment-proxy in order to keep the same proxy addresses?

The canonical deployment process uses either this proxy or the one deployed by the Safe team.

Do you mean that we must use deterministic-deployment-proxy in order to keep the same proxy addresses?

Yes, this is required to keep addresses the same

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nlordell nlordell Awaiting requested review from nlordell nlordell is a code owner automatically assigned from safe-global/safe-protocol

@akshay-ap akshay-ap Awaiting requested review from akshay-ap akshay-ap is a code owner automatically assigned from safe-global/safe-protocol

@mmv08 mmv08 Awaiting requested review from mmv08 mmv08 is a code owner automatically assigned from safe-global/safe-protocol

@remedcu remedcu Awaiting requested review from remedcu remedcu is a code owner automatically assigned from safe-global/safe-protocol

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@IntegralTeam @mmv08