Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Adjust meta tag to fix PWA header position #4738

Merged
merged 2 commits into from
Jan 9, 2025
Merged

Conversation

usame-algan
Copy link
Member

@usame-algan usame-algan commented Jan 6, 2025

What it solves

Resolves #4434

How this PR fixes it

  • Adds the viewport-fit=cover directive to the meta tags -> This moves the whole app up into the "Dynamic island" on iOS
  • Adds a padding (for PWA only) to the header and main element to move them down again and adds a background so the content is not visible when scrolling

How to test it

  1. Open the app on mobile (iOS and Android and iOS with a device without the notch), add it as a PWA to your Home Screen and open it again
  2. Scroll up and down
  3. Observe nothing is visible above the header
  4. Open the app on web
  5. Scroll up and down
  6. Observe the header is at the very top
  7. Make sure it works both in landscape and portrait mode on mobile

Screenshots

image

image

Checklist

  • I've tested the branch on mobile 📱
  • I've documented how it affects the analytics (if at all) 📊
  • I've written a unit/e2e test for it (if applicable) 🧑‍💻

@usame-algan usame-algan requested a review from katspaugh January 6, 2025 13:57
Copy link

github-actions bot commented Jan 6, 2025

Copy link

github-actions bot commented Jan 6, 2025

📦 Next.js Bundle Analysis for @safe-global/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

⚠️ Global Bundle Size Increased

Page Size (compressed)
global 1 MB (🟡 +14.97 KB)
Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

Thirty-two Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load
/ 508 B (🟢 -2 B) 1 MB
/address-book 23.21 KB (🟡 +142 B) 1.03 MB
/apps 35.8 KB (🟡 +2.08 KB) 1.04 MB
/apps/custom 33.87 KB (🟡 +2.08 KB) 1.04 MB
/apps/open 55.57 KB (🟡 +1.96 KB) 1.06 MB
/balances 29.88 KB (🟡 +176 B) 1.03 MB
/balances/nfts 9.52 KB (🟢 -24 B) 1.01 MB
/bridge 2.56 KB (🟡 +1 B) 1.01 MB
/cookie 8.77 KB (🟡 +1 B) 1.01 MB
/home 61.38 KB (🟡 +2.12 KB) 1.06 MB
/new-safe/advanced-create 26.38 KB (🟢 -75 B) 1.03 MB
/new-safe/create 25.52 KB (🟢 -74 B) 1.03 MB
/new-safe/load 6.08 KB (🟢 -5 B) 1.01 MB
/privacy 14.57 KB (🟡 +2 B) 1.02 MB
/settings/appearance 2.25 KB (🟡 +2 B) 1.01 MB
/settings/environment-variables 3.27 KB (🟢 -1 B) 1.01 MB
/settings/modules 4.06 KB (🟡 +1 B) 1.01 MB
/settings/notifications 21 KB (🟢 -324 B) 1.02 MB
/settings/safe-apps 20.35 KB (🟡 +2.08 KB) 1.02 MB
/settings/security 2.34 KB (🟡 +1 B) 1.01 MB
/settings/setup 30.82 KB (🟡 +92 B) 1.03 MB
/share/safe-app 7.56 KB (🟢 -5 B) 1.01 MB
/stake 618 B (🟢 -1 B) 1 MB
/swap 764 B (🟡 +4 B) 1 MB
/terms 12.93 KB (🟡 +1 B) 1.02 MB
/transactions 99.47 KB (🟡 +2.9 KB) 1.1 MB
/transactions/history 99.43 KB (🟡 +2.9 KB) 1.1 MB
/transactions/messages 60.26 KB (🟡 +1.96 KB) 1.06 MB
/transactions/msg 56.51 KB (🟡 +1.96 KB) 1.06 MB
/transactions/queue 49.37 KB (🟡 +1.97 KB) 1.05 MB
/transactions/tx 48.73 KB (🟡 +1.96 KB) 1.05 MB
/welcome/accounts 409 B (🟡 +2 B) 1 MB
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this.

Copy link

github-actions bot commented Jan 6, 2025

Coverage report for apps/web

St.
Category Percentage Covered / Total
🟡 Statements 74.11% 14578/19670
🔴 Branches 51.7% 3478/6727
🔴 Functions 57.12% 2065/3615
🟡 Lines 75.66% 13224/17479

Test suite run success

1758 tests passing in 238 suites.

Report generated by 🧪jest coverage report action from 0d91a02

Copy link
Member

@katspaugh katspaugh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@francovenica
Copy link
Contributor

I'm trying to reproduce the issue first in current prod and dev and I don't see it, so I cannot confirm the fix does what it is supposed to do.
Am I'm missing something?

Check this gif. It was taken in a chrome emulator, but it looks the same in an iPhone and Android device:
safe twitching

@usame-algan
Copy link
Member Author

I'm trying to reproduce the issue first in current prod and dev and I don't see it, so I cannot confirm the fix does what it is supposed to do. Am I'm missing something?

This needs to be tested on an actual phone, not in the Browser with a mobile emulator

@francovenica
Copy link
Contributor

Ok, The app needed to be added to the homepage as a "stand alone app" from the browser.
Thanks Usame for the clarification

I was able to compare current prod with this PR and the fix looks good

@usame-algan usame-algan merged commit 95d5711 into dev Jan 9, 2025
15 checks passed
@usame-algan usame-algan deleted the pwa-header branch January 9, 2025 08:47
@github-actions github-actions bot locked and limited conversation to collaborators Jan 9, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Page content is visible above the header on mobile view
3 participants