Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: initialize Firebase only if projectId is present in options #4750

Merged
merged 1 commit into from
Jan 8, 2025

Conversation

tmjssz
Copy link
Collaborator

@tmjssz tmjssz commented Jan 8, 2025

What it solves

Fixes error message when Firebase is initialized:

FirebaseError: Installations: Missing App configuration value: "projectId" (installations/missing-app-config-values).

Screenshot 2025-01-08 at 16 30 31

How this PR fixes it

apps/web/src/services/push-notifications/firebase.ts: Added the isFirebaseOptions type guard function to ensure that the FIREBASE_OPTIONS object contains a projectId.

How to test it (on localhost)

  1. Clear NEXT_PUBLIC_FIREBASE_OPTIONS_STAGING in .env file
  2. Load app while monitoring the dev console
  3. Observe that the error message (see above) is not logged

Screenshots

Checklist

  • I've tested the branch on mobile 📱
  • I've documented how it affects the analytics (if at all) 📊
  • I've written a unit/e2e test for it (if applicable) 🧑‍💻

@tmjssz tmjssz requested a review from katspaugh January 8, 2025 15:38
Copy link

github-actions bot commented Jan 8, 2025

📦 Next.js Bundle Analysis for @safe-global/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

⚠️ Global Bundle Size Increased

Page Size (compressed)
global 1.04 MB (🟡 +54.03 KB)
Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

Thirty-one Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load
/ 508 B (🟢 -2 B) 1.04 MB
/address-book 23.21 KB (🟡 +142 B) 1.06 MB
/apps 35.8 KB (🟡 +2.08 KB) 1.08 MB
/apps/custom 33.87 KB (🟡 +2.08 KB) 1.07 MB
/apps/open 55.57 KB (🟡 +1.96 KB) 1.1 MB
/balances 29.88 KB (🟡 +176 B) 1.07 MB
/balances/nfts 9.52 KB (🟢 -24 B) 1.05 MB
/bridge 2.56 KB (🟡 +2 B) 1.04 MB
/cookie 8.77 KB (🟡 +1 B) 1.05 MB
/home 61.38 KB (🟡 +2.12 KB) 1.1 MB
/new-safe/advanced-create 26.38 KB (🟢 -70 B) 1.07 MB
/new-safe/create 25.52 KB (🟢 -71 B) 1.07 MB
/privacy 14.57 KB (🟡 +2 B) 1.06 MB
/settings/appearance 2.25 KB (🟡 +2 B) 1.04 MB
/settings/environment-variables 3.27 KB (🟢 -1 B) 1.04 MB
/settings/modules 4.06 KB (🟡 +1 B) 1.05 MB
/settings/notifications 6.33 KB (🟢 -14.99 KB) 1.05 MB
/settings/safe-apps 20.35 KB (🟡 +2.08 KB) 1.06 MB
/settings/security 2.34 KB (🟡 +1 B) 1.04 MB
/settings/setup 30.82 KB (🟡 +92 B) 1.07 MB
/share/safe-app 7.56 KB (🟢 -5 B) 1.05 MB
/stake 618 B (🟢 -1 B) 1.04 MB
/swap 761 B (🟡 +1 B) 1.04 MB
/terms 12.93 KB (🟡 +1 B) 1.05 MB
/transactions 99.47 KB (🟡 +2.9 KB) 1.14 MB
/transactions/history 99.43 KB (🟡 +2.9 KB) 1.14 MB
/transactions/messages 60.26 KB (🟡 +1.96 KB) 1.1 MB
/transactions/msg 56.51 KB (🟡 +1.96 KB) 1.1 MB
/transactions/queue 49.37 KB (🟡 +1.97 KB) 1.09 MB
/transactions/tx 48.73 KB (🟡 +1.96 KB) 1.09 MB
/welcome/accounts 409 B (🟡 +2 B) 1.04 MB
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this.

Copy link

github-actions bot commented Jan 8, 2025

Coverage report for apps/web

St.
Category Percentage Covered / Total
🟡 Statements
74.28% (-0.01% 🔻)
14760/19872
🔴 Branches
51.99% (+0.01% 🔼)
3532/6793
🔴 Functions
57.37% (+0.01% 🔼)
2095/3652
🟡 Lines
75.82% (-0.01% 🔻)
13393/17665
Show files with reduced coverage 🔻
St.
File Statements Branches Functions Lines
🟢
... / firebase.ts
79.17% (-7.79% 🔻)
76.92% (+4.2% 🔼)
100%
80% (-9.47% 🔻)

Test suite run success

1792 tests passing in 242 suites.

Report generated by 🧪jest coverage report action from 278e433

Copy link
Member

@katspaugh katspaugh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@tmjssz tmjssz merged commit c43e6cb into dev Jan 8, 2025
15 checks passed
@tmjssz tmjssz deleted the fix/missing-firebase-projectId-error branch January 8, 2025 16:14
@github-actions github-actions bot locked and limited conversation to collaborators Jan 8, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants