Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat(Tx details): share block + view on explorer for historical txs #4987

Open
wants to merge 5 commits into
base: dev
Choose a base branch
from

Conversation

katspaugh
Copy link
Member

@katspaugh katspaugh commented Feb 14, 2025

What it solves

As per the discussion here:

  • Enable the Share button also for txs in history
  • No emphasis on signers in history as the tx is already fully signed
  • Show a "View on explorer" link in history
  • Remove the old share icon in the top right corner of tx details
  • The share block in the queue is unchanged
Screenshot 2025-02-14 at 10 45 52

@katspaugh katspaugh requested a review from iamacook February 14, 2025 10:55
Copy link

github-actions bot commented Feb 14, 2025

Branch preview

❌ Deploy failed!

Copy link

github-actions bot commented Feb 14, 2025

📦 Next.js Bundle Analysis for @safe-global/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

⚠️ Global Bundle Size Increased

Page Size (compressed)
global 1.06 MB (🟡 +74.76 KB)
Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

Thirty-five Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load
/ 509 B (🟢 -1 B) 1.06 MB
/address-book 23.21 KB (🟡 +140 B) 1.08 MB
/apps 37.39 KB (🟡 +3.67 KB) 1.1 MB
/apps/custom 35.46 KB (🟡 +3.67 KB) 1.1 MB
/apps/open 55.36 KB (🟡 +1.75 KB) 1.12 MB
/balances 29.68 KB (🟢 -23 B) 1.09 MB
/balances/nfts 10.92 KB (🟡 +1.38 KB) 1.07 MB
/bridge 2.55 KB (🟢 -4 B) 1.06 MB
/cookie 8.77 KB (🟡 +1 B) 1.07 MB
/home 62.95 KB (🟡 +3.69 KB) 1.12 MB
/licenses 2.46 KB (🟢 -1 B) 1.06 MB
/new-safe/advanced-create 26.38 KB (🟢 -77 B) 1.09 MB
/new-safe/create 25.52 KB (🟢 -70 B) 1.09 MB
/privacy 14.57 KB (🟡 +2 B) 1.08 MB
/settings/appearance 2.25 KB (🟡 +1 B) 1.06 MB
/settings/cookies 1.87 KB (🟡 +1 B) 1.06 MB
/settings/data 1.79 KB (🟢 -1 B) 1.06 MB
/settings/environment-variables 3.28 KB (🟡 +1 B) 1.07 MB
/settings/modules 2.88 KB (🟢 -1.18 KB) 1.06 MB
/settings/notifications 7.49 KB (🟢 -13.82 KB) 1.07 MB
/settings/safe-apps 20.15 KB (🟡 +1.87 KB) 1.08 MB
/settings/security 2.34 KB (🟡 +2 B) 1.06 MB
/settings/setup 30.97 KB (🟡 +246 B) 1.09 MB
/share/safe-app 7.55 KB (🟢 -9 B) 1.07 MB
/stake 617 B (🟢 -2 B) 1.06 MB
/swap 763 B (🟡 +3 B) 1.06 MB
/terms 12.93 KB (🟡 +1 B) 1.07 MB
/transactions 99.46 KB (🟡 +2.88 KB) 1.16 MB
/transactions/history 99.42 KB (🟡 +2.88 KB) 1.16 MB
/transactions/messages 60.84 KB (🟡 +2.54 KB) 1.12 MB
/transactions/msg 57.1 KB (🟡 +2.54 KB) 1.12 MB
/transactions/queue 49.36 KB (🟡 +1.96 KB) 1.11 MB
/transactions/tx 48.72 KB (🟡 +1.95 KB) 1.11 MB
/welcome 6.93 KB (🟢 -2 B) 1.07 MB
/welcome/accounts 408 B (🟡 +1 B) 1.06 MB
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this.

Copy link

github-actions bot commented Feb 14, 2025

Coverage report for apps/web

St.
Category Percentage Covered / Total
🟡 Statements
77.29% (-0% 🔻)
14201/18374
🔴 Branches
56.05% (-0.05% 🔻)
3563/6357
🟡 Functions
62.2% (-0.04% 🔻)
2119/3407
🟡 Lines
78.76% (-0% 🔻)
12823/16282
Show new covered files 🐣
St.
File Statements Branches Functions Lines
🟡
... / TxShareLink.tsx
64.29% 0% 0% 69.23%
Show files with reduced coverage 🔻
St.
File Statements Branches Functions Lines
🟡
... / index.tsx
60% (-4.29% 🔻)
0% 0%
60% (-9.23% 🔻)

Test suite run success

1828 tests passing in 249 suites.

Report generated by 🧪jest coverage report action from 2f43939

}: {
id: string
children: ReactElement
eventLabel: 'share-block'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: this should be located in the relevant events file.

apps/web/src/components/transactions/TxShareLink/index.tsx Outdated Show resolved Hide resolved
@katspaugh
Copy link
Member Author

Looking at analytics, the old Share button is still being actively used after introducing the old button, so I'll restore to co-exist with the new one.

Screenshot 2025-02-14 at 15 54 45

@katspaugh katspaugh marked this pull request as draft February 14, 2025 15:55
@katspaugh katspaugh marked this pull request as ready for review February 14, 2025 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants