Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Orgs): Update sidebar #5019

Merged
merged 2 commits into from
Feb 18, 2025
Merged

feat(Orgs): Update sidebar #5019

merged 2 commits into from
Feb 18, 2025

Conversation

usame-algan
Copy link
Member

What it solves

Resolves #5003

How this PR fixes it

  • Uses the correct icons for the sidebar navigation
  • Adds OrgsSidebar into the existing Drawer to support toggle on smaller viewports
  • Highlights the current nav item

How to test it

  1. Open an org
  2. Observe the sidebar has the correct icons
  3. Navigate through each page
  4. Observe the correct nav item is highlighted
  5. View the page with a smaller viewport
  6. Observe the sidebar disappears and a toggle in the header appears
  7. Press the toggle
  8. Observe the sidebar toggles open

Screenshots

Screenshot 2025-02-17 at 21 02 22

Checklist

  • I've tested the branch on mobile 📱
  • I've documented how it affects the analytics (if at all) 📊
  • I've written a unit/e2e test for it (if applicable) 🧑‍💻

Copy link

github-actions bot commented Feb 17, 2025

Copy link

📦 Next.js Bundle Analysis for @safe-global/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

⚠️ Global Bundle Size Increased

Page Size (compressed)
global 1.07 MB (🟡 +81.37 KB)
Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

New Pages Added

The following pages were added to the bundle from the code in this PR:

Page Size (compressed) First Load
/organizations/[orgId] 1.53 KB 1.07 MB
/organizations/[orgId]/members 580 B 1.07 MB
/organizations/[orgId]/safeAccounts 422 B 1.07 MB
/organizations/[orgId]/settings 416 B 1.07 MB
/welcome/organizations 409 B 1.07 MB

Thirty-four Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load
/ 509 B (🟢 -1 B) 1.07 MB
/address-book 23.17 KB (🟡 +99 B) 1.09 MB
/apps 35.75 KB (🟡 +2.03 KB) 1.1 MB
/apps/custom 33.82 KB (🟡 +2.03 KB) 1.1 MB
/apps/open 55.36 KB (🟡 +1.75 KB) 1.12 MB
/balances 29.68 KB (🟢 -25 B) 1.1 MB
/balances/nfts 9.31 KB (🟢 -236 B) 1.08 MB
/bridge 2.55 KB (🟢 -4 B) 1.07 MB
/cookie 8.77 KB (🟡 +1 B) 1.08 MB
/home 63.88 KB (🟡 +4.62 KB) 1.13 MB
/licenses 2.46 KB (🟢 -1 B) 1.07 MB
/new-safe/advanced-create 26.38 KB (🟢 -77 B) 1.09 MB
/new-safe/create 25.52 KB (🟢 -70 B) 1.09 MB
/privacy 14.57 KB (🟡 +2 B) 1.08 MB
/settings/appearance 2.25 KB (🟡 +2 B) 1.07 MB
/settings/data 1.79 KB (🟢 -1 B) 1.07 MB
/settings/environment-variables 3.28 KB (🟡 +1 B) 1.07 MB
/settings/modules 2.88 KB (🟢 -1.18 KB) 1.07 MB
/settings/notifications 7.49 KB (🟢 -13.82 KB) 1.08 MB
/settings/safe-apps 20.15 KB (🟡 +1.87 KB) 1.09 MB
/settings/security 2.34 KB (🟡 +2 B) 1.07 MB
/settings/setup 30.97 KB (🟡 +245 B) 1.1 MB
/share/safe-app 7.55 KB (🟢 -9 B) 1.08 MB
/stake 617 B (🟢 -2 B) 1.07 MB
/swap 763 B (🟡 +3 B) 1.07 MB
/terms 12.93 KB (🟡 +1 B) 1.08 MB
/transactions 99.46 KB (🟡 +2.88 KB) 1.17 MB
/transactions/history 99.42 KB (🟡 +2.88 KB) 1.17 MB
/transactions/messages 60.25 KB (🟡 +1.95 KB) 1.13 MB
/transactions/msg 56.5 KB (🟡 +1.95 KB) 1.12 MB
/transactions/queue 49.36 KB (🟡 +1.96 KB) 1.12 MB
/transactions/tx 48.72 KB (🟡 +1.96 KB) 1.12 MB
/welcome 6.93 KB (🟢 -2 B) 1.08 MB
/welcome/accounts 405 B (🟢 -2 B) 1.07 MB
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this.

Copy link

Coverage report for apps/web

St.
Category Percentage Covered / Total
🟡 Statements
77.24% (-0.02% 🔻)
14207/18393
🔴 Branches
56.06% (-0.03% 🔻)
3562/6354
🟡 Functions
62.09% (-0.02% 🔻)
2119/3413
🟡 Lines
78.72% (-0.01% 🔻)
12828/16296
Show new covered files 🐣
St.
File Statements Branches Functions Lines
🟡
... / useIsOrganizationRoute.ts
50% 0% 0% 60%
Show files with reduced coverage 🔻
St.
File Statements Branches Functions Lines
🔴
... / useIsSidebarRoute.ts
37.5% (-0.96% 🔻)
0% 0%
37.5% (-0.96% 🔻)
🟢
... / useTxPendingStatuses.ts
77.5% (-0.83% 🔻)
64.06% (-1.56% 🔻)
68.18%
86.41% (-0.97% 🔻)

Test suite run success

1828 tests passing in 249 suites.

Report generated by 🧪jest coverage report action from f937c0d

@usame-algan usame-algan requested a review from jmealy February 18, 2025 07:50
Copy link
Contributor

@jmealy jmealy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

@usame-algan usame-algan merged commit 5a56e86 into orgs-epic Feb 18, 2025
11 checks passed
@usame-algan usame-algan deleted the orgs-sidebar branch February 18, 2025 10:57
@github-actions github-actions bot locked and limited conversation to collaborators Feb 18, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants