Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix overflowing selected of options #1756

Open
wants to merge 45 commits into
base: master
Choose a base branch
from
Open

Fix overflowing selected of options #1756

wants to merge 45 commits into from

Commits on Jan 5, 2023

  1. Add aria-multiselectable 

    - Implemented as described in the MDN docs:
  - https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/Attributes/aria-multiselectable
  - https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/Attributes/aria-selected

Signed-off-by: Christopher Ng <chrng8@gmail.com>
    @Pytal
    Pytal committed Jan 5, 2023
    Configuration menu
    Copy the full SHA
    5e1fad0 View commit details
    Browse the repository at this point in the history

Commits on Jan 20, 2023

  1. Fix dropdown not opening after closing 

    Signed-off-by: Christopher Ng <chrng8@gmail.com>
    @Pytal
    Pytal committed Jan 20, 2023
    Configuration menu
    Copy the full SHA
    5baaa76 View commit details
    Browse the repository at this point in the history

Commits on Jan 27, 2023

  1. Merge pull request sagalbot#1 from nextcloud-deps/enh/a11y-aria-multi… 

    …selectable
    @Pytal
    Pytal authored Jan 27, 2023
    Configuration menu
    Copy the full SHA
    246df60 View commit details
    Browse the repository at this point in the history

  2. Merge pull request sagalbot#2 from nextcloud-deps/fix/open-dropdown-o… 

    …n-enter
    @Pytal
    Pytal authored Jan 27, 2023
    Configuration menu
    Copy the full SHA
    61f4211 View commit details
    Browse the repository at this point in the history

  3. Handle keyboard focus 

    Signed-off-by: Christopher Ng <chrng8@gmail.com>
    @Pytal
    Pytal committed Jan 27, 2023
    Configuration menu
    Copy the full SHA
    ac01c0f View commit details
    Browse the repository at this point in the history

  4. Darken default dropdown active bg color 

    - To meet WCAG AA contrast requirements

Signed-off-by: Christopher Ng <chrng8@gmail.com>
    @Pytal
    Pytal committed Jan 27, 2023
    Configuration menu
    Copy the full SHA
    73e0b04 View commit details
    Browse the repository at this point in the history

  5. Add CSS variable and class styles 

    Signed-off-by: Christopher Ng <chrng8@gmail.com>
    @Pytal
    Pytal committed Jan 27, 2023
    Configuration menu
    Copy the full SHA
    bc141b7 View commit details
    Browse the repository at this point in the history

  6. Merge pull request sagalbot#3 from nextcloud-deps/enh/a11y-keyboard-f… 

    …ocus-border
    @Pytal
    Pytal authored Jan 27, 2023
    Configuration menu
    Copy the full SHA
    15be9de View commit details
    Browse the repository at this point in the history

  7. v3.21.0 

    Signed-off-by: Christopher Ng <chrng8@gmail.com>
    @Pytal
    Pytal committed Jan 27, 2023
    Configuration menu
    Copy the full SHA
    6b6582b View commit details
    Browse the repository at this point in the history

  8. Merge pull request sagalbot#4 from nextcloud-deps/v3.21.0

    @Pytal
    Pytal authored Jan 27, 2023
    Configuration menu
    Copy the full SHA
    16dbb47 View commit details
    Browse the repository at this point in the history

Commits on Jan 31, 2023

  1. Add @nextcloud namespace to package name 

    Signed-off-by: Christopher Ng <chrng8@gmail.com>
    @Pytal
    Pytal committed Jan 31, 2023
    Configuration menu
    Copy the full SHA
    bf4309f View commit details
    Browse the repository at this point in the history

  2. Merge pull request sagalbot#5 from nextcloud-deps/nextcloud-namespace

    @Pytal
    Pytal authored Jan 31, 2023
    Configuration menu
    Copy the full SHA
    2e6f141 View commit details
    Browse the repository at this point in the history

  3. v3.21.1 

    Signed-off-by: Christopher Ng <chrng8@gmail.com>
    @Pytal
    Pytal committed Jan 31, 2023
    Configuration menu
    Copy the full SHA
    7bdd579 View commit details
    Browse the repository at this point in the history

  4. Merge pull request sagalbot#6 from nextcloud-deps/v3.21.1

    @Pytal
    Pytal authored Jan 31, 2023
    Configuration menu
    Copy the full SHA
    d7d042a View commit details
    Browse the repository at this point in the history

Commits on Feb 1, 2023

  1. Fix keyboard focus not returning to input after clear 

    - "Clear" for single-select
- "Deselect" for multi-select

Signed-off-by: Christopher Ng <chrng8@gmail.com>
    @Pytal
    Pytal committed Feb 1, 2023
    Configuration menu
    Copy the full SHA
    12466c9 View commit details
    Browse the repository at this point in the history

  2. Merge pull request sagalbot#7 from nextcloud-deps/fix/a11y-clear-kb-f… 

    …ocus
    @Pytal
    Pytal authored Feb 1, 2023
    Configuration menu
    Copy the full SHA
    9ef870b View commit details
    Browse the repository at this point in the history

  3. v3.21.2 

    Signed-off-by: Christopher Ng <chrng8@gmail.com>
    @Pytal
    Pytal committed Feb 1, 2023
    Configuration menu
    Copy the full SHA
    9e36609 View commit details
    Browse the repository at this point in the history

  4. Merge pull request sagalbot#8 from nextcloud-deps/v3.21.2

    @Pytal
    Pytal authored Feb 1, 2023
    Configuration menu
    Copy the full SHA
    4eed18c View commit details
    Browse the repository at this point in the history

Commits on Feb 7, 2023

  1. Fix return focus after keyboard deselect 

    Signed-off-by: Christopher Ng <chrng8@gmail.com>
    @Pytal
    Pytal committed Feb 7, 2023
    Configuration menu
    Copy the full SHA
    aab477b View commit details
    Browse the repository at this point in the history

  2. Merge pull request sagalbot#9 from nextcloud-deps/fix/a11y-kb-focus-d… 

    …eselect
    @Pytal
    Pytal authored Feb 7, 2023
    Configuration menu
    Copy the full SHA
    0cae604 View commit details
    Browse the repository at this point in the history

  3. Use browser agnostic handling for keyboard deselect focus 

    Signed-off-by: Christopher Ng <chrng8@gmail.com>
    @Pytal
    Pytal committed Feb 7, 2023
    Configuration menu
    Copy the full SHA
    89a6f98 View commit details
    Browse the repository at this point in the history

Commits on Feb 8, 2023

  1. Merge pull request sagalbot#10 from nextcloud-deps/fix/a11y-agnostic-… 

    …focus
    @Pytal
    Pytal authored Feb 8, 2023
    Configuration menu
    Copy the full SHA
    2d5bfe4 View commit details
    Browse the repository at this point in the history

  2. v3.21.3 

    Signed-off-by: Christopher Ng <chrng8@gmail.com>
    @Pytal
    Pytal committed Feb 8, 2023
    Configuration menu
    Copy the full SHA
    cd294db View commit details
    Browse the repository at this point in the history

  3. Merge pull request sagalbot#11 from nextcloud-deps/v3.21.3

    @Pytal
    Pytal authored Feb 8, 2023
    Configuration menu
    Copy the full SHA
    d3c78a5 View commit details
    Browse the repository at this point in the history

Commits on Feb 9, 2023

  1. Limit number of dropdown options 

    Signed-off-by: Christopher Ng <chrng8@gmail.com>
    @Pytal
    Pytal committed Feb 9, 2023
    Configuration menu
    Copy the full SHA
    a7ccfe1 View commit details
    Browse the repository at this point in the history

  2. Merge pull request sagalbot#12 from nextcloud-deps/enh/limit-options

    @Pytal
    Pytal authored Feb 9, 2023
    Configuration menu
    Copy the full SHA
    e2b333b View commit details
    Browse the repository at this point in the history

Commits on Feb 10, 2023

  1. v3.22.0 

    Signed-off-by: Christopher Ng <chrng8@gmail.com>
    @Pytal
    Pytal committed Feb 10, 2023
    Configuration menu
    Copy the full SHA
    f91b453 View commit details
    Browse the repository at this point in the history

  2. Merge pull request sagalbot#13 from nextcloud-deps/v3.22.0

    @Pytal
    Pytal authored Feb 10, 2023
    Configuration menu
    Copy the full SHA
    d61274d View commit details
    Browse the repository at this point in the history

Commits on Feb 11, 2023

  1. Fix calculated dropdown list width 

    - The calculated dropdown list width, passed to `calculatePosition()`
  when `appendToBody` is true, should be equal to the toggle width
- Width is calculated before the dropdown list is appended to `body` and
  is still a child of the Select component
- If the Select component is mounted within a container that overflows
  and shows a scrollbar when a child dropdown list is opened, the toggle
  width is calculated with the scrollbar taken into account and
  therefore will equal the original toggle width minus the scrollbar
  width
- When appended to `body` the dropdown list does not overflow the
  container
- Thus `calculatePosition()` is given a width less than the toggle width
- To fix this discrepancy we mount the dropdown list to `body` before
  the calculation instead of after

Signed-off-by: Christopher Ng <chrng8@gmail.com>
    @Pytal
    Pytal committed Feb 11, 2023
    Configuration menu
    Copy the full SHA
    9bfce3f View commit details
    Browse the repository at this point in the history

  2. Merge pull request sagalbot#14 from nextcloud-deps/fix/append-body-ca… 

    …lc-width
    @Pytal
    Pytal authored Feb 11, 2023
    Configuration menu
    Copy the full SHA
    750521e View commit details
    Browse the repository at this point in the history

Commits on Feb 14, 2023

  1. Update package metadata 

    - Point to correct package under nextcloud namespace

Signed-off-by: Christopher Ng <chrng8@gmail.com>
    @Pytal
    Pytal committed Feb 14, 2023
    Configuration menu
    Copy the full SHA
    72f78a6 View commit details
    Browse the repository at this point in the history

  2. Update README 

    - Update package name
- Update badges

Signed-off-by: Christopher Ng <chrng8@gmail.com>
    @Pytal
    Pytal committed Feb 14, 2023
    Configuration menu
    Copy the full SHA
    0f9d47f View commit details
    Browse the repository at this point in the history

  3. Merge pull request sagalbot#15 from nextcloud-deps/nextcloud-package

    @Pytal
    Pytal authored Feb 14, 2023
    Configuration menu
    Copy the full SHA
    8a70129 View commit details
    Browse the repository at this point in the history

  4. v3.22.1 

    Signed-off-by: Christopher Ng <chrng8@gmail.com>
    @Pytal
    Pytal committed Feb 14, 2023
    Configuration menu
    Copy the full SHA
    e2581dc View commit details
    Browse the repository at this point in the history

  5. Merge pull request sagalbot#16 from nextcloud-deps/v3.22.1

    @Pytal
    Pytal authored Feb 14, 2023
    Configuration menu
    Copy the full SHA
    1839cbe View commit details
    Browse the repository at this point in the history

  6. v3.22.2 

    Signed-off-by: Christopher Ng <chrng8@gmail.com>
    @Pytal
    Pytal committed Feb 14, 2023
    Configuration menu
    Copy the full SHA
    eb20f15 View commit details
    Browse the repository at this point in the history

  7. Merge pull request sagalbot#17 from nextcloud-deps/v3.22.2

    @Pytal
    Pytal authored Feb 14, 2023
    Configuration menu
    Copy the full SHA
    28f12fb View commit details
    Browse the repository at this point in the history

Commits on Feb 15, 2023

  1. fix: Overflowing selected options 

    Signed-off-by: Ferdinand Thiessen <rpm@fthiessen.de>
    @susnux
    susnux committed Feb 15, 2023
    Configuration menu
    Copy the full SHA
    71dd57d View commit details
    Browse the repository at this point in the history

Commits on Feb 28, 2023

  1. Merge pull request sagalbot#18 from susnux/master

    @Pytal
    Pytal authored Feb 28, 2023
    Configuration menu
    Copy the full SHA
    9294fdc View commit details
    Browse the repository at this point in the history

Commits on May 31, 2023

  1. fix(docs): Fix CI shield on readme 

    Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
    @susnux
    susnux committed May 31, 2023
    Configuration menu
    Copy the full SHA
    7730cb5 View commit details
    Browse the repository at this point in the history

  2. Merge pull request sagalbot#19 from susnux/fix/readme

    @Pytal
    Pytal authored May 31, 2023
    Configuration menu
    Copy the full SHA
    f7d3452 View commit details
    Browse the repository at this point in the history

Commits on Jun 22, 2023

  1. Allow disabling focus reset 

    Signed-off-by: Christopher Ng <chrng8@gmail.com>
    @Pytal
    Pytal committed Jun 22, 2023
    Configuration menu
    Copy the full SHA
    eb042bb View commit details
    Browse the repository at this point in the history

Commits on Jun 23, 2023

  1. Merge pull request sagalbot#20 from nextcloud-deps/enh/reset-focus

    @Pytal
    Pytal authored Jun 23, 2023
    Configuration menu
    Copy the full SHA
    6ae2091 View commit details
    Browse the repository at this point in the history

  2. v3.23.0 

    Signed-off-by: Christopher Ng <chrng8@gmail.com>
    @Pytal
    Pytal committed Jun 23, 2023
    Configuration menu
    Copy the full SHA
    93bdaab View commit details
    Browse the repository at this point in the history

  3. Merge pull request sagalbot#21 from nextcloud-deps/v3.23.0

    @Pytal
    Pytal authored Jun 23, 2023
    Configuration menu
    Copy the full SHA
    6ee86a9 View commit details
    Browse the repository at this point in the history